Re: [Emacs-diffs] master 2291d9a: Fix python.el for Emacs 24, bump ELPA version to 0.26.1 (Bug#30633)

[Noam Postavsky]

On Tue, Feb 27, 2018 at 9:03 PM, Stefan Monnier
<address@hidden> wrote:

>> +                                  "
>> +Overlapping strings detected (start=%d, last-end=%d)")
>
> You can put a \ at the end of the first line to avoid inserting
> a newline in the string's content.

Oops. I meant to do that, but somehow the backslash disappeared on me
(a paredit boosted typo, I guess).

>> -  (set (make-local-variable 'prettify-symbols-alist)
>> -       python--prettify-symbols-alist)
>> +  (when (and (boundp 'prettify-symbols-alist)
>> +             (boundp 'python--prettify-symbols-alist))
>> +    (set (make-local-variable 'prettify-symbols-alist)
>> +         python--prettify-symbols-alist))
>
> Setting prettify-symbols-alist when it's not defined should be harmless.
> So I'm curious what was the motivation behind the (boundp
> 'prettify-symbols-alist) test?
> Could we replace it with a (defvar prettify-symbols-alist)?

Yeah, I was just going through the compiler warnings, so defvar could work too.

> [ As for python--prettify-symbols-alist, it's defined above, so it will
>   always be 'boundp'.  ]

Oh, I see, in Emacs 24, the compiler doesn't realize that
define-obsolete-variable-alias defines a variable, so it still warns
about it. Actually, we could just use the non-obsolete
python-prettify-symbols-alist name there, right?