[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master 2291d9a: Fix python.el for Emacs 24, bump ELPA
From: |
Stefan Monnier |
Subject: |
Re: [Emacs-diffs] master 2291d9a: Fix python.el for Emacs 24, bump ELPA version to 0.26.1 (Bug#30633) |
Date: |
Wed, 28 Feb 2018 00:10:49 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
> Oh, I see, in Emacs 24, the compiler doesn't realize that
> define-obsolete-variable-alias defines a variable, so it still warns
> about it. Actually, we could just use the non-obsolete
> python-prettify-symbols-alist name there, right?
Indeed, we should use the non-obsolete name (and I now see also that the
define-obsolete-variable-alias is placed after the defvar, whereas it
should always come *before* (so that, in case one of the two is already
set when we get to define-obsolete-variable-alias we can just "share"
that setting, whereas if we do it afterwards we end up having to choose
between two conflicting settings)).
Stefan