[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master 108ce84 2/2: xref--next-error-function: Move xr
|
From: |
Eli Zaretskii |
|
Subject: |
Re: [Emacs-diffs] master 108ce84 2/2: xref--next-error-function: Move xref's window point |
|
Date: |
Wed, 28 Feb 2018 17:28:52 +0200 |
> From: Dmitry Gutov <address@hidden>
> Date: Wed, 28 Feb 2018 04:13:22 +0200
>
> Eli, what would you say about backporting this to emacs-26?
>
> This change is limited in scope, it fixes annoying "looping" behavior
> I've seen in some cases, and it adds window point movement you've asked
> for before in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=20489#110
>
> > branch: master
> > commit 108ce84432d597f92637ea74bd0a094224d157de
> > Author: Dmitry Gutov <address@hidden>
> > Commit: Dmitry Gutov <address@hidden>
> >
> > xref--next-error-function: Move xref's window point
> >
> > * lisp/progmodes/xref.el (xref--next-error-function): Move
> > xref's window point if it's visible. When we don't do that,
> > navigation can start looping after a while.
Sorry, this doesn't tell which problem(s) it attempts to fix, and
there are no references to discussions or bug reports that could help
me figure that out. Without that, I cannot make up my mind about the
importance of this fix.