Re: emacs-26 c87d04e: Avoid aborts in 'md5'

[Andreas Schwab]

On Feb 28 2018, Eli Zaretskii <address@hidden> wrote:

>> From: Andreas Schwab <address@hidden>
>> Cc: address@hidden,  Eli Zaretskii <address@hidden>
>> Date: Wed, 28 Feb 2018 10:15:04 +0100
>> 
>> > See bug#30627.
>> 
>> So the CHECK_STRING should be put in the else branch.
>
> In general, safe code should check STRINGP before using SSDATA, so the
> way I did it is safer (and also more future-proof).

All branches already use SSDATA or SBYTES before that, so nothing is
gained.

Andreas.

-- 
Andreas Schwab, SUSE Labs, address@hidden
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."