Re: Let's make C-M-w in isearch yank symbol, not delete character

[Juri Linkov]

>>> > Why only set those properties in the :setter rather tan just do it at
>>> > top-level?  Also, would it be possible to avoid having to list those
>>> > commands and instead treat as `isearch-move` any command which uses the
>>> > handle-shift-selection?
>>
>>> Supporting only commands which use the handle-shift-selection
>>> makes the most sense.  I tested this to confirm it works as expected:
>>
>>> diff --git a/lisp/isearch.el b/lisp/isearch.el
>>> index 84b121a..245bf8a 100644
>>> --- a/lisp/isearch.el
>>> +++ b/lisp/isearch.el
>>> @@ -2433,8 +2448,8 @@ isearch-pre-command-hook
>>>        (setq this-command 'isearch-edit-string))
>>>       ;; Don't terminate the search for motion commands.
>>>       ((or (and (eq search-exit-option 'move)
>>> -               (symbolp this-command)
>>> -               (eq (get this-command 'isearch-move) t))
>>> +               (stringp (nth 1 (interactive-form this-command)))
>>> +               (string-match-p "^^" (nth 1 (interactive-form 
>>> this-command))))
>>>            (and (eq search-exit-option 'shift-move)
>>>                 this-command-keys-shift-translated))
>>>        (setq this-command-keys-shift-translated nil)
>>
>> Please don't do this.  handle-shift-selection (whatever that might be)
>> is a different feature from the isearch extension, and users should be
>> able to customize them independently from each other.  Correction: MUST
>> be able to customize them independently.
>
> This solution avoids the flaws of the isearch-allow-scroll feature 
> that causes "customization hell" by requiring maintaining a long list of
> (put 'command 'isearch-scroll t) minutiae, and requiring adding the same
> for every new command.  The feature should be smart enough to deduce
> a reasonable default set of supported commands, and adjustable enough
> to allow adding/deleting commands to/from the default set.

This patch clarifies the idea:

diff --git a/lisp/isearch.el b/lisp/isearch.el
index 84b121a..56a44d8 100644
--- a/lisp/isearch.el
+++ b/lisp/isearch.el
@@ -2434,7 +2449,10 @@ isearch-pre-command-hook
      ;; Don't terminate the search for motion commands.
      ((or (and (eq search-exit-option 'move)
                (symbolp this-command)
-               (eq (get this-command 'isearch-move) t))
+               (or (eq (get this-command 'isearch-move) 'enabled)
+                   (and (not (eq (get this-command 'isearch-move) 'disabled))
+                        (stringp (nth 1 (interactive-form this-command)))
+                        (string-match-p "^^" (nth 1 (interactive-form 
this-command))))))
           (and (eq search-exit-option 'shift-move)
                this-command-keys-shift-translated))
       (setq this-command-keys-shift-translated nil)