emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Support variable-unquoting syntax in bat-mode


From: Eli Zaretskii
Subject: Re: Support variable-unquoting syntax in bat-mode
Date: Thu, 15 Mar 2018 15:25:04 +0200

> From: Jostein Kjønigsen <address@hidden>
> Cc: address@hidden, address@hidden
> Date: Wed, 14 Mar 2018 21:48:53 +0100
> 
>  --- lisp/progmodes/bat-mode.el~ 2018-01-03 13:09:15.000000000 +0200
>  +++ lisp/progmodes/bat-mode.el 2018-03-14 17:10:44.238856900 +0200
>  @@ -84,6 +84,8 @@
>            . 'bat-label-face)
>          ("\\_<\\(defined\\|set\\)\\_>[ \t]*\\(\\(\\sw\\|\\s_\\)+\\)"
>            (2 font-lock-variable-name-face))
>  +        ("%~\\([1-9]\\)"
>  +         (1 font-lock-variable-name-face))
>          ("%\\([^%~ \n]+\\)%?"
>            (1 font-lock-variable-name-face))
>          ("!\\([^!%~ \n]+\\)!?"  ; delayed-expansion !variable!
> 
> That works for me, and running "make check", it seems all tests still pass.
> 
> If I were to amend this in any way, it would be extending  the range check 
> from 0 (zero) to 9, (as opposed 1 to
> 9).
> 
> %0  is the program being executed, and in certain cases a normal parameter to 
> extract (for instance in
> generic logging-statements).

Right, fixed to use 0 and pushed to the master branch, including a
test for this new feature.

Thanks.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]