Re: bug#26323: 25.1; Closing frames (in fullscreen) under Mac OS cause immediate crash

[Alan Third]

On Sun, Mar 18, 2018 at 07:17:34AM -0400, David Reitter wrote:
> On Mar 18, 2018, at 7:15 AM, Alan Third <address@hidden> wrote:
> 
> >> It reproduced in a mid-2016 build, and in a current build (based on the 25 
> >> branch).
> > 
> > It was fixed after that. I can’t reproduce it in Emacs 26.
> 
> Is this going to be backported to 25?

No, I’m pretty sure it isn’t.

> > I want to know how Matthew got his copy of Emacs as the code to turn
> > off Sierra tab support is only included when built on Sierra+ or when
> > using the right build options.
> 
> That suggests the “fix” is to turn off tab support - is that right?

I’m not sure, to be honest, but Matthew said he could only reproduce
the problem with tab support on.

I have tab support on in the OS and can’t reproduce it.

The relevant code is:

  /* macOS Sierra automatically enables tabbed windows.  We can't
     allow this to be enabled until it's available on a Free system.
     Currently it only happens by accident and is buggy anyway. */
#if defined (NS_IMPL_COCOA) \
  && MAC_OS_X_VERSION_MAX_ALLOWED >= 101200
#if MAC_OS_X_VERSION_MIN_REQUIRED < 101200
  if ([win respondsToSelector: @selector(setTabbingMode:)])
#endif
    [win setTabbingMode: NSWindowTabbingModeDisallowed];
#endif

at the bottom of initFrameFromEmacs in nsterm.m.

It’s possible we need to include similar code for fullscreen (I can’t
remember if the fullscreen code uses initFrameFromEmacs), but it seems
OK here.
-- 
Alan Third