[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: State of the overlay tree branch?
From: |
Eli Zaretskii |
Subject: |
Re: State of the overlay tree branch? |
Date: |
Wed, 21 Mar 2018 08:47:18 +0200 |
> From: Sebastian Sturm <address@hidden>
> Date: Wed, 21 Mar 2018 01:36:38 +0100
>
> this is the profiler report I get for the slow case (BTW, is there a way
> to have the profiler resolve functions within line-number-at-pos?
Yes: load simple.el manually before running the benchmark.
> with perf, the ("self") time taken by buf_charpos_to_bytepos increases
> from ~60% (fast case) to >98%. This is the diff generated by perf diff
> <fast.perf> <slow.perf>:
>
> # Event 'cycles'
> #
> # Baseline Delta Shared Object Symbol
>
> # ........ ....... ....................
> ..........................................
> #
> 57.77% +40.30% emacs-27.0.50 [.] buf_charpos_to_bytepos
This seems to confirm Stefan's guess that converting character
positions to byte positions takes most of the time, which might make
sense with a lot of overlays (because each overlay uses 2 markers).
Does your code call line-number-at-pos at random positions in the
buffer, or are the positions close to one another? If the latter, you
might be better off calling count-lines directly, starting at the line
where you previously calculated the line number, instead of calling
line-number-at-pos, which always begins at point-min.
- Re: State of the overlay tree branch?, (continued)
- Re: State of the overlay tree branch?, Sebastian Sturm, 2018/03/18
- Re: State of the overlay tree branch?, Eli Zaretskii, 2018/03/19
- Re: State of the overlay tree branch?, Sebastian Sturm, 2018/03/19
- Re: State of the overlay tree branch?, Eli Zaretskii, 2018/03/19
- Re: State of the overlay tree branch?, Stefan Monnier, 2018/03/19
- Re: State of the overlay tree branch?, Sebastian Sturm, 2018/03/19
- Re: State of the overlay tree branch?, Stefan Monnier, 2018/03/19
- Re: State of the overlay tree branch?, Sebastian Sturm, 2018/03/19
- Re: State of the overlay tree branch?, Eli Zaretskii, 2018/03/20
- Re: State of the overlay tree branch?, Sebastian Sturm, 2018/03/20
- Re: State of the overlay tree branch?,
Eli Zaretskii <=
- Re: State of the overlay tree branch?, Stefan Monnier, 2018/03/22
- Re: State of the overlay tree branch?, Sebastian Sturm, 2018/03/22
- Re: State of the overlay tree branch?, Sebastian Sturm, 2018/03/22
- Re: State of the overlay tree branch?, Stefan Monnier, 2018/03/22
- Re: State of the overlay tree branch?, Sebastian Sturm, 2018/03/22
- Re: State of the overlay tree branch?, Stefan Monnier, 2018/03/23
- Re: State of the overlay tree branch?, Sebastian Sturm, 2018/03/23
- Re: State of the overlay tree branch?, Eli Zaretskii, 2018/03/23
- Re: State of the overlay tree branch?, Stefan Monnier, 2018/03/23
- Re: State of the overlay tree branch?, Noam Postavsky, 2018/03/23