[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master d826037 3/3: Remove the need for temacs.in
From: |
Stefan Monnier |
Subject: |
Re: [Emacs-diffs] master d826037 3/3: Remove the need for temacs.in |
Date: |
Thu, 11 Apr 2019 15:35:53 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
> Please don't do this. Computing a fingerprint over temacs.in factors link
> layout information into the fingerprint hash. Your approach doesn't. It's
> possible to link Emacs in different ways from the same object files and
> produce different binaries. I don't think a little build speedup is worth
> the safety loss.
BTW, regarding this fingerprint: following this discussion, I see that
we actually don't know for sure what is preserved between two different
runs of `ld` and more to the point, there is no guarantee.
So, how'bout we don't compute a fingerprint at all.
Instead we generate a UUID: this way we can have our cake (no need for
a separate temacs.in) and eat it too (even very subtle changes `ld` does
between two different runs will lead to different "fingerprints").
Stefan
- Re: [Emacs-diffs] master d826037 3/3: Remove the need for temacs.in, (continued)
- Re: [Emacs-diffs] master d826037 3/3: Remove the need for temacs.in, Eli Zaretskii, 2019/04/14
- Re: [Emacs-diffs] master d826037 3/3: Remove the need for temacs.in, Stefan Monnier, 2019/04/14
- Re: [Emacs-diffs] master d826037 3/3: Remove the need for temacs.in, dancol, 2019/04/14
- Re: [Emacs-diffs] master d826037 3/3: Remove the need for temacs.in, Stefan Monnier, 2019/04/14
- Re: [Emacs-diffs] master d826037 3/3: Remove the need for temacs.in, Eli Zaretskii, 2019/04/14
- Re: [Emacs-diffs] master d826037 3/3: Remove the need for temacs.in, Paul Eggert, 2019/04/14
Re: [Emacs-diffs] master d826037 3/3: Remove the need for temacs.in,
Stefan Monnier <=