[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Unbreak build when building without GMP support.
From: |
Eli Zaretskii |
Subject: |
Re: [PATCH] Unbreak build when building without GMP support. |
Date: |
Wed, 24 Apr 2019 22:30:31 +0300 |
> From: Philipp Stephani <address@hidden>
> Date: Wed, 24 Apr 2019 21:19:54 +0200
> Cc: Emacs developers <address@hidden>, Philipp Stephani <address@hidden>
>
> Am Mi., 24. Apr. 2019 um 21:06 Uhr schrieb Eli Zaretskii <address@hidden>:
> >
> > > From: Philipp Stephani <address@hidden>
> > > Date: Wed, 24 Apr 2019 20:49:34 +0200
> > > Cc: Emacs developers <address@hidden>, Philipp Stephani <address@hidden>
> > >
> > > > Btw, why are we including emacs-module.h in lisp.h? IME, this usually
> > > > causes trouble, so it is best to avoid that.
> > >
> > > lisp.h needs types from emacs-module.h to define Lisp_Module_Function.
> >
> > A single data type? I'd rather move XMODULE_FUNCTION to
> > emacs-module.c, and the data type definition and all the other related
> > stuff to emacs-module.h. It isn't worth the hassle.
>
> We shouldn't move anything to emacs-module.h because it's a public
> header, to be used outside of Emacs.
Then keep them in lisp.h, but make them self-sufficient. Which types
does Lisp_Module_Function need that are defined by emacs-module.h?
> What hassle are you talking about? There is no hassle. We have been
> including emacs-module.h in lisp.h for years, and there was never any
> problem.
I had one just today. And the patch you are now proposing includes a
time bomb: files that include lisp.h will have emacs-module.h with a
different definition of emacs_mpz than those which include
emacs-module.h directly, depending on whether they do or don't define
EMACS_MODULE_GMP etc. It's confusing and error prone. The only other
header lisp.h includes, thread.h, was also a source of many
compilation problems, and will be again if we change the thread
machinery.
- Re: [PATCH 2/2] Add module functions to convert from and to big integers., (continued)
- Re: [PATCH 2/2] Add module functions to convert from and to big integers., Philipp Stephani, 2019/04/24
- Re: [PATCH 2/2] Add module functions to convert from and to big integers., Eli Zaretskii, 2019/04/24
- Re: [PATCH 2/2] Add module functions to convert from and to big integers., Philipp Stephani, 2019/04/24
- Re: [PATCH 2/2] Add module functions to convert from and to big integers., Eli Zaretskii, 2019/04/24
- Re: [PATCH 2/2] Add module functions to convert from and to big integers., Philipp Stephani, 2019/04/24
- [PATCH] Unbreak build when building without GMP support., Philipp Stephani, 2019/04/24
- Re: [PATCH] Unbreak build when building without GMP support., Eli Zaretskii, 2019/04/24
- Re: [PATCH] Unbreak build when building without GMP support., Philipp Stephani, 2019/04/24
- Re: [PATCH] Unbreak build when building without GMP support., Eli Zaretskii, 2019/04/24
- Re: [PATCH] Unbreak build when building without GMP support., Philipp Stephani, 2019/04/24
- Re: [PATCH] Unbreak build when building without GMP support.,
Eli Zaretskii <=
- Re: [PATCH] Unbreak build when building without GMP support., Philipp Stephani, 2019/04/24
- Re: [PATCH] Unbreak build when building without GMP support., Eli Zaretskii, 2019/04/25
- Re: [PATCH] Unbreak build when building without GMP support., Eli Zaretskii, 2019/04/25
- Re: [PATCH] Unbreak build when building without GMP support., Philipp Stephani, 2019/04/25
- Re: [PATCH] Unbreak build when building without GMP support., Philipp Stephani, 2019/04/24
- Re: [PATCH 2/2] Add module functions to convert from and to big integers., Stefan Monnier, 2019/04/24
- Re: [PATCH 2/2] Add module functions to convert from and to big integers., Paul Eggert, 2019/04/24
- Re: [PATCH 2/2] Add module functions to convert from and to big integers., Stefan Monnier, 2019/04/24
- Re: [PATCH 2/2] Add module functions to convert from and to big integers., Philipp Stephani, 2019/04/24
- Re: [PATCH 2/2] Add module functions to convert from and to big integers., Paul Eggert, 2019/04/24