emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add user option to disable location in bookmarks


From: Basil L. Contovounesios
Subject: Re: [PATCH] Add user option to disable location in bookmarks
Date: Sun, 21 Jun 2020 10:56:44 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Jamie Beardslee <beardsleejamie@gmail.com> writes:

>  (defun save-place--setup-hooks (add)
>    (cond
>     (add
>      (add-hook 'find-file-hook #'save-place-find-file-hook t)
> +    (eval-after-load "bookmark"
> +      '(add-hook 'bookmark-after-jump-hook #'save-place-bookmark-hook t))

with-eval-after-load is preferred to eval-after-load, but is it
necessary?  add-hook knows how to deal with as of yet undefined hook
variables.

>      (add-hook 'dired-initial-position-hook #'save-place-dired-hook)
>      (unless noninteractive
>        (add-hook 'kill-emacs-hook #'save-place-kill-emacs-hook))
> @@ -334,6 +344,10 @@ save-place-find-file-hook
>            ;; and make sure it will be saved again for later
>            (setq save-place-mode t)))))

-- 
Basil



reply via email to

[Prev in Thread] Current Thread [Next in Thread]