[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: New Git hooks for checking file names in commit messages
From: |
Eli Zaretskii |
Subject: |
Re: New Git hooks for checking file names in commit messages |
Date: |
Sat, 22 Apr 2023 09:11:55 +0300 |
> Date: Fri, 21 Apr 2023 10:44:10 -0700
> From: Jim Porter <jporterbugs@gmail.com>
> Cc: emacs-devel@gnu.org, eliz@gnu.org
>
> On 4/21/2023 9:44 AM, Jim Porter wrote:
> > I tried to be as lenient as possible with the Git hooks so that they
> > only catch things that would be a problem for admin/authors.el, though
> > there are some small differences regarding multi-line lists of files.
>
> After thinking about this for a bit, I came up with a way to match
> admin/authors.el in the hooks (at least, to the best of my knowledge).
> This should mean that the hooks will report exactly the same errors as
> admin/authors.el.
>
> With this patch, there's no restriction on putting a "*" in the first
> column of a commit message, so long as that paragraph doesn't also have
> a ":" in it (just like admin/authors.el).
>
> Eli, what do you think? I've run this against the 5000 latest commits
> and the results look right (though I haven't looked as thoroughly as
> last time).
I think the hooks should follow the GNU Standards (which are also our
conventions), not their particular expressions in algorithms used by
authors.el.
- New Git hooks for checking file names in commit messages, Jim Porter, 2023/04/21
- Re: New Git hooks for checking file names in commit messages, John Yates, 2023/04/21
- Re: New Git hooks for checking file names in commit messages, Jim Porter, 2023/04/21
- Re: New Git hooks for checking file names in commit messages, Jim Porter, 2023/04/21
- Re: New Git hooks for checking file names in commit messages,
Eli Zaretskii <=
- Re: New Git hooks for checking file names in commit messages, Jim Porter, 2023/04/22
- Re: New Git hooks for checking file names in commit messages, Eli Zaretskii, 2023/04/22
- Re: New Git hooks for checking file names in commit messages, Jim Porter, 2023/04/22
- Re: New Git hooks for checking file names in commit messages, John Yates, 2023/04/22
Re: New Git hooks for checking file names in commit messages, Alan Mackenzie, 2023/04/21