emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master bb9133f09da: * lisp/emacs-lisp/ert.el (ert-run-tests-batch-an


From: Stefan Monnier
Subject: Re: master bb9133f09da: * lisp/emacs-lisp/ert.el (ert-run-tests-batch-and-exit): Inhibit interaction
Date: Mon, 14 Aug 2023 11:05:10 -0400
User-agent: Gnus/5.13 (Gnus v5.13)

> Oh, I think I see: `inhibit-interaction` is probably tested too early,
> e.g. upon entry to `read-event` (which can return without user
> interaction if there's enough `unread-command-events` and friends)
> instead of upon entry to the actual code that waits for user input, so
> it doesn't quite do what I thought it would.

And even if we move the check to the actual place in `read_char` where
we wait for user input, it's still too early because it burps in those
places in the tests where we `read-event` only for the timeout (i.e. we
do wait, but no user-interaction is needed).


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]