emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [ELPA] New package: ert-font-lock


From: Eli Zaretskii
Subject: Re: [ELPA] New package: ert-font-lock
Date: Sat, 18 Nov 2023 14:43:09 +0200

> From: Po Lu <luangruo@yahoo.com>
> Cc: Vladimir Kazanov <vekazanov@gmail.com>,  emacs-devel@gnu.org
> Date: Sat, 18 Nov 2023 20:07:42 +0800
> 
> Philip Kaludercic <philipk@posteo.net> writes:
> 
> > ELPA shouls be fine.
> 
> Since this is an adjunct to ERT, which is plausibly useful for the unit
> testing of Emacs fontification code itself, I think such code should be
> part of Emacs proper.

I won't object to including this, FWIW.

> BTW, this code requires cl-lib for a meager one macro.  Please replace
> 
>       (cl-incf curline)
> 
> with
> 
>       (setq curline (1+ curline))
> 
> that cl-lib might not be loaded either at compile-time or runtime.
> There is no rationale for requiring cl-lib so as to employ a single
> macro once.

Doesn't this library require ert?  if it does, cl-lib is already
loaded by ert.

But if people like cl-incf so much, we could just add incf to subr.el
or something.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]