[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] User-defined fringe tooltips (a request for review)
From: |
Eli Zaretskii |
Subject: |
Re: [PATCH] User-defined fringe tooltips (a request for review) |
Date: |
Sun, 31 Mar 2024 11:36:44 +0300 |
> From: Vladimir Kazanov <vekazanov@gmail.com>
> Date: Wed, 27 Mar 2024 10:59:50 +0000
> Cc: emacs-devel@gnu.org
>
> Attached is a v2 patch (for discussion, not yet finished) that
> demonstrates the approach. Examples of what works and what doesn't:
>
> ;; single spec, list of specs, vector of specs all work now
> (insert (propertize "foo" 'display '(right-fringe left-arrow warning
> "right tooltip")))foo
> (insert (propertize "foo" 'display '((left-fringe right-arrow
> warning "left tooltip"))))foo
> (insert (propertize "foo" 'display '[(right-fringe left-arrow
> warning "right tooltip")]))
Like I said earlier: I think it would be better to have the tooltip
text in a separate property, not as part of the 'display' property
spec.
Also, I don't see a need for recording the positions in the glyph_row
structure, because finding the glyph that corresponds to buffer/string
text with that special property is easy enough.