[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master e720ba62193 1/2: (mouse-wheel-buttons): Map old-style wheel b
From: |
Eshel Yaron |
Subject: |
Re: master e720ba62193 1/2: (mouse-wheel-buttons): Map old-style wheel buttons to actual wheel events |
Date: |
Wed, 10 Apr 2024 20:35:26 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> I wonder whether/why we should keep the bindings that use
>> mouse-wheel-up/down-event here. Do I understand correctly that since we
>> already bind wheel-down/up directly, we should now be able to simply
>> remove these additional bindings?
>
> I had an earlier patch which was "more radical" in this way, but in the
> end went with this half-way patch where people can set
> `mouse-wheel-buttons` to nil and recover the old behavior.
>
> We could remove most of those (if not all) uses of
> `mouse-wheel-up/down/left/right-event`, but I don't think there's
> a hurry to do that.
Got it, thanks.
> Admittedly, the ones in `completion-preview.el` could go because they're
> new in Emacs-30 so there's no previous behavior to preserve.
Indeed. I think I'll remove them then, that way we won't need to
require mwheel in completion-preview.el anymore :)