[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: MPS: face-cache
From: |
Gerd Möllmann |
Subject: |
Re: MPS: face-cache |
Date: |
Sun, 28 Apr 2024 16:31:41 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Gerd Möllmann <gerd.moellmann@gmail.com>
>> Cc: eller.helmut@gmail.com, emacs-devel@gnu.org
>> Date: Sun, 28 Apr 2024 14:26:16 +0200
>>
>> Gerd Möllmann <gerd.moellmann@gmail.com> writes:
>>
>> > Eli Zaretskii <eliz@gnu.org> writes:
>> >
>> >> hash_index = hash_lookup_get_hash (hash_table, key, &hash_code);
>> >
>> > And hash_table above is composition_hash_table which is staticpro'd. So
>> > I think that works OOTB, Nice!
>>
>> I take that back. The reference to key in struct composition is of
>> course a separate reference from what's in the hash table, so it should
>> either be traced, and be in an ambiguous root so that it can't move.
>
> Can't we make the key an unmovable object?
I've pushed Helmut's solution now, which does that.
- Re: MPS: face-cache, (continued)
- Re: MPS: face-cache, Po Lu, 2024/04/29
- Re: MPS: face-cache, Gerd Möllmann, 2024/04/29
- Re: MPS: face-cache, Helmut Eller, 2024/04/29
- Re: MPS: face-cache, Gerd Möllmann, 2024/04/29
- Re: MPS: face-cache, Helmut Eller, 2024/04/29
- Re: MPS: face-cache, Gerd Möllmann, 2024/04/29
- Re: MPS: face-cache, Eli Zaretskii, 2024/04/28
- Re: MPS: face-cache,
Gerd Möllmann <=
- Re: MPS: face-cache, Eli Zaretskii, 2024/04/28