[Emacs-diffs] Changes to emacs/admin/FOR-RELEASE

[Richard M . Stallman]

Index: emacs/admin/FOR-RELEASE
diff -c emacs/admin/FOR-RELEASE:1.27 emacs/admin/FOR-RELEASE:1.28
*** emacs/admin/FOR-RELEASE:1.27        Sat Nov 13 01:42:56 2004
--- emacs/admin/FOR-RELEASE     Tue Nov 16 17:22:25 2004
***************
*** 2,11 ****
  
  * NEW FEATURES
  
- ** Test the mbox branch of Rmail.
- 
- ** Install the mbox branch of Rmail.
- 
  ** Face remapping.
  
  ** Let mouse-1 follow links.
--- 2,7 ----
***************
*** 36,41 ****
--- 32,76 ----
  
  ** Clean up flymake.el to follow Emacs Lisp conventions.
  
+ * BUGS
+ 
+ ** Bug in url-http-parse-headers, reported in
+ From: Vivek Dasmohapatra <address@hidden>
+ Date: Tue, 28 Sep 2004 16:13:13 +0100
+ 
+ Fetching a url with url-retrieve can reult in an anrbitrary buffer
+ being killed if a 401 (or possibly a 407) result is encountered:
+ 
+ url-http-parse-headers calls url-http-handle-authentication, 
+ which can call url-retrieve. 
+ 
+ This results in the current buffer being killed, and a new http buffer 
+ being generated. However, when the old http buffer is killed, emacs 
+ picks the top buffer from the list as the new current buffer, so by the 
+ time we get to the end of url-http-parse-headers, _that_ buffer is marked 
+ as dead even though it is not necessarily a url buffer, so next time the 
+ url libraries reap their dead buffers, an innocent bystander buffer is 
+ killed instead (and an obsolete http buffer may be left lying around too).
+ 
+ A possible fix (which I am currently using) is to call set-buffer
+ on the return value of url-http-parse-headers:
+ 
+       (case url-http-response-status
+       (401
+        ;; The request requires user authentication.  The response
+        ;; MUST include a WWW-Authenticate header field containing a
+        ;; challenge applicable to the requested resource.  The
+        ;; client MAY repeat the request with a suitable
+        ;; Authorization header field.
+        (url-mark-buffer-as-dead (current-buffer))
+        (set-buffer (url-http-handle-authentication nil)))
+ etc ....
+ 
+ which makes sure that it is the right http buffer that is current when 
+ we come to mark the http buffers as dead.
+ 
+ 
+ 
  * GTK RELATED BUGS
  
  ** Make GTK scrollbars behave like others w.r.t. overscrolling.
***************
*** 237,243 ****
  lispref/compile.texi     "Luc Teirlinck"
  lispref/control.texi     "Luc Teirlinck"
  lispref/customize.texi
! lispref/debugging.texi
  lispref/display.texi
  lispref/edebug.texi
  lispref/elisp.texi       "Luc Teirlinck"
--- 272,278 ----
  lispref/compile.texi     "Luc Teirlinck"
  lispref/control.texi     "Luc Teirlinck"
  lispref/customize.texi
! lispref/debugging.texi   Joakim Verona <address@hidden>
  lispref/display.texi
  lispref/edebug.texi
  lispref/elisp.texi       "Luc Teirlinck"