emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] Changes to emacs/lisp/files.el,v


From: Glenn Morris
Subject: [Emacs-diffs] Changes to emacs/lisp/files.el,v
Date: Fri, 24 Aug 2007 03:03:52 +0000

CVSROOT:        /sources/emacs
Module name:    emacs
Changes by:     Glenn Morris <gm>       07/08/24 03:03:52

Index: files.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/files.el,v
retrieving revision 1.921
retrieving revision 1.922
diff -u -b -r1.921 -r1.922
--- files.el    22 Aug 2007 04:36:52 -0000      1.921
+++ files.el    24 Aug 2007 03:03:52 -0000      1.922
@@ -3175,9 +3175,6 @@
   (let ((umask (default-file-modes))
        (dir (or (file-name-directory to-name)
                 default-directory)))
-    ;; Can't delete or create files in a read-only directory.
-    (unless (file-writable-p dir)
-      (signal 'file-error (list "Directory is not writable" dir)))
     (unwind-protect
        (progn
          ;; Create temp files with strict access rights.  It's easy to
@@ -3186,11 +3183,6 @@
          (set-default-file-modes ?\700)
          (while (condition-case ()
                     (progn
-                      ;; If we allow for the possibility of something
-                      ;; creating the file between delete and copy
-                      ;; (below), we must also allow for the
-                      ;; possibility of something deleting it between
-                      ;; a file-exists-p check and a delete.
                       (condition-case nil
                           (delete-file to-name)
                         (file-error nil))
@@ -3199,8 +3191,6 @@
                   (file-already-exists t))
            ;; The file was somehow created by someone else between
            ;; `delete-file' and `copy-file', so let's try again.
-           ;; Does that every actually happen in practice?
-           ;; This is a potential infloop, which seems bad...
            ;; rms says "I think there is also a possible race
            ;; condition for making backup files" (emacs-devel 20070821).
            nil))




reply via email to

[Prev in Thread] Current Thread [Next in Thread]