[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Emacs-diffs] emacs/lisp ChangeLog mail/rmailsum.el
From: |
Glenn Morris |
Subject: |
[Emacs-diffs] emacs/lisp ChangeLog mail/rmailsum.el |
Date: |
Thu, 19 Feb 2009 03:32:26 +0000 |
CVSROOT: /sources/emacs
Module name: emacs
Changes by: Glenn Morris <gm> 09/02/19 03:32:26
Modified files:
lisp : ChangeLog
lisp/mail : rmailsum.el
Log message:
(rmail-summary-by-topic): Doc fix.
Regexp-quote default argument taken from current subject.
(rmail-new-summary-1): Error if empty summary. (Bug#2333)
CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/emacs/lisp/ChangeLog?cvsroot=emacs&r1=1.15354&r2=1.15355
http://cvs.savannah.gnu.org/viewcvs/emacs/lisp/mail/rmailsum.el?cvsroot=emacs&r1=1.170&r2=1.171
Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/emacs/emacs/lisp/ChangeLog,v
retrieving revision 1.15354
retrieving revision 1.15355
diff -u -b -r1.15354 -r1.15355
--- ChangeLog 18 Feb 2009 18:36:11 -0000 1.15354
+++ ChangeLog 19 Feb 2009 03:32:23 -0000 1.15355
@@ -1,3 +1,21 @@
+2009-02-19 Glenn Morris <address@hidden>
+
+ * mail/rmailsum.el (rmail-summary-by-topic): Doc fix.
+ Regexp-quote default argument taken from current subject.
+ (rmail-new-summary-1): Error if empty summary. (Bug#2333)
+
+ * mail/rmail-spam-filter.el (rmail-get-new-mail-filter-spam):
+ Move here from rmail.el. Be more careful about error-handling.
+ Restore the feature of temporarily setting all old messages
+ undeleted before expunging (removed 2009-02-18).
+
+ * mail/rmail.el (rsf-beep, rsf-sleep-after-message, rmail-spam-filter):
+ Don't declare.
+ (rmail-get-new-mail-filter-spam): Declare. Move definition to
+ rmail-spam-filter.el.
+ (rmail-get-new-mail-1): Move the beep and sleep to
+ rmail-get-new-mail-filter-spam.
+
2009-02-18 Martin Rudalics <address@hidden>
* cus-edit.el (custom-group-value-create): Insert some
Index: mail/rmailsum.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/mail/rmailsum.el,v
retrieving revision 1.170
retrieving revision 1.171
diff -u -b -r1.170 -r1.171
--- mail/rmailsum.el 15 Feb 2009 02:52:16 -0000 1.170
+++ mail/rmailsum.el 19 Feb 2009 03:32:26 -0000 1.171
@@ -150,12 +150,13 @@
;;;###autoload
(defun rmail-summary-by-topic (subject &optional whole-message)
"Display a summary of all messages with the given SUBJECT.
-Normally checks the Subject field of headers;
-but if WHOLE-MESSAGE is non-nil (prefix arg given),
- look in the whole message.
+Normally checks just the Subject field of headers; but with prefix
+argument WHOLE-MESSAGE is non-nil, looks in the whole message.
SUBJECT is a string of regexps separated by commas."
(interactive
- (let* ((subject (rmail-simplified-subject))
+ ;; We quote the default subject, because if it contains regexp
+ ;; special characters (eg "?"), it can fail to match itself. (Bug#2333)
+ (let* ((subject (regexp-quote (rmail-simplified-subject)))
(prompt (concat "Topics to summarize by (regexp"
(if subject ", default current subject" "")
"): ")))
@@ -282,18 +283,18 @@
rmail-new-summary-line-count)))
(setq summary-msgs (nreverse summary-msgs)))
(narrow-to-region old-min old-max)))))
-
;; Temporarily, while summary buffer is unfinished,
;; we "don't have" a summary.
- ;;
+ (setq rmail-summary-buffer nil)
+ (unless summary-msgs
+ (kill-buffer sumbuf)
+ (error "Nothing to summarize"))
;; I have not a clue what this clause is doing. If you read this
;; chunk of code and have a clue, then please email that clue to
;; address@hidden
- (setq rmail-summary-buffer nil)
(if rmail-enable-mime
(with-current-buffer rmail-buffer
(setq rmail-summary-buffer nil)))
-
(save-excursion
(let ((rbuf (current-buffer))
(total rmail-total-messages))