[Emacs-diffs] emacs/lisp ChangeLog mail/rmail.el

[Glenn Morris]

CVSROOT:        /sources/emacs
Module name:    emacs
Changes by:     Glenn Morris <gm>       09/02/20 04:35:02

Modified files:
        lisp           : ChangeLog 
        lisp/mail      : rmail.el 

Log message:
        (rmail-speedbar-buttons): Only add regular files.
        (rmail-speedbar-find-file): Use rmail rather than find-file.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/emacs/lisp/ChangeLog?cvsroot=emacs&r1=1.15364&r2=1.15365
http://cvs.savannah.gnu.org/viewcvs/emacs/lisp/mail/rmail.el?cvsroot=emacs&r1=1.510&r2=1.511

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/emacs/emacs/lisp/ChangeLog,v
retrieving revision 1.15364
retrieving revision 1.15365
diff -u -b -r1.15364 -r1.15365
--- ChangeLog   20 Feb 2009 04:19:57 -0000      1.15364
+++ ChangeLog   20 Feb 2009 04:35:00 -0000      1.15365
@@ -1,3 +1,8 @@
+2009-02-20  Glenn Morris  <address@hidden>
+
+       * mail/rmail.el (rmail-speedbar-buttons): Only add regular files.
+       (rmail-speedbar-find-file): Use rmail rather than find-file.
+
 2009-02-20  Roland Winkler  <address@hidden>
 
        * textmodes/bibtex.el (bibtex-autokey-titleword-ignore): Fix

Index: mail/rmail.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/mail/rmail.el,v
retrieving revision 1.510
retrieving revision 1.511
diff -u -b -r1.510 -r1.511
--- mail/rmail.el       19 Feb 2009 03:30:41 -0000      1.510
+++ mail/rmail.el       20 Feb 2009 04:35:01 -0000      1.511
@@ -3816,6 +3816,7 @@
     (define-key rmail-speedbar-key-map "M"
       'rmail-speedbar-move-message-to-folder-on-line)))
 
+;; FIXME unused?
 (defvar rmail-speedbar-menu-items
   '(["Read Folder" speedbar-edit-line t]
     ["Move message to folder" rmail-speedbar-move-message-to-folder-on-line
@@ -3857,12 +3858,12 @@
             (df (directory-files (with-current-buffer buffer
                                     default-directory)
                                  nil rmail-speedbar-match-folder-regexp)))
-       (while df
+       (dolist (file df)
+         (when (file-regular-p file)
          (speedbar-insert-button "<M>" 'speedbar-button-face 'highlight
-                                 'rmail-speedbar-move-message (car df))
-         (speedbar-insert-button (car df) 'speedbar-file-face 'highlight
-                                 'rmail-speedbar-find-file nil t)
-         (setq df (cdr df)))))))
+                                   'rmail-speedbar-move-message file)
+           (speedbar-insert-button file 'speedbar-file-face 'highlight
+                                   'rmail-speedbar-find-file nil t)))))))
 
 (defun rmail-speedbar-button (text token indent)
   "Execute an rmail command specified by TEXT.
@@ -3875,7 +3876,7 @@
 TOKEN and INDENT are not used."
   (speedbar-with-attached-buffer
    (message "Loading in RMAIL file %s..." text)
-   (find-file text)))
+   (rmail text)))
 
 (defun rmail-speedbar-move-message-to-folder-on-line ()
   "If the current line is a folder, move current message to it."
@@ -3887,6 +3888,7 @@
          (forward-char -2)
          (speedbar-do-function-pointer)))))
 
+;; FIXME loses the directory part.
 (defun rmail-speedbar-move-message (text token indent)
   "From button TEXT, copy current message to the rmail file specified by TOKEN.
 TEXT and INDENT are not used."
@@ -3894,10 +3896,10 @@
    (message "Moving message to %s" token)
    (rmail-output token)))
 
-; Functions for setting, getting and encoding the POP password.
-; The password is encoded to prevent it from being easily accessible
-; to "prying eyes."  Obviously, this encoding isn't "real security,"
-; nor is it meant to be.
+;; Functions for setting, getting and encoding the POP password.
+;; The password is encoded to prevent it from being easily accessible
+;; to "prying eyes."  Obviously, this encoding isn't "real security,"
+;; nor is it meant to be.
 
 ;;;###autoload
 (defun rmail-set-remote-password (password)