[Emacs-diffs] emacs/lisp ChangeLog dired.el

[Martin Rudalics]

CVSROOT:        /sources/emacs
Module name:    emacs
Changes by:     Martin Rudalics <m061211>       09/05/15 15:00:42

Modified files:
        lisp           : ChangeLog dired.el 

Log message:
        (dired-pop-to-buffer): Try to make this behave the
        Emacs 22 way (Bug#1806).

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/emacs/lisp/ChangeLog?cvsroot=emacs&r1=1.15639&r2=1.15640
http://cvs.savannah.gnu.org/viewcvs/emacs/lisp/dired.el?cvsroot=emacs&r1=1.422&r2=1.423

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/emacs/emacs/lisp/ChangeLog,v
retrieving revision 1.15639
retrieving revision 1.15640
diff -u -b -r1.15639 -r1.15640
--- ChangeLog   14 May 2009 03:50:53 -0000      1.15639
+++ ChangeLog   15 May 2009 15:00:32 -0000      1.15640
@@ -1,3 +1,8 @@
+2009-05-15  Martin Rudalics  <address@hidden>
+
+       * dired.el (dired-pop-to-buffer): Try to make this behave the
+       Emacs 22 way (Bug#1806).
+
 2009-05-14  Chong Yidong  <address@hidden>
 
        * frame.el (minibuffer-frame-alist): Doc fix (Bug#3276).

Index: dired.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/dired.el,v
retrieving revision 1.422
retrieving revision 1.423
diff -u -b -r1.422 -r1.423
--- dired.el    2 Apr 2009 22:16:23 -0000       1.422
+++ dired.el    15 May 2009 15:00:42 -0000      1.423
@@ -2686,8 +2686,14 @@
 
 (defun dired-pop-to-buffer (buf)
   "Pop up buffer BUF in a way suitable for Dired."
-  ;; Don't split window horizontally.  (Bug#1806)
-  (let (split-width-threshold)
+  (let ((split-window-preferred-function
+        (lambda (window)
+          (or (and (window-splittable-p (selected-window))
+                   ;; Try to split the selected window vertically if
+                   ;; that's possible.  (Bug#1806)
+                   (split-window-vertically))
+              ;; Otherwise, try to split WINDOW sensibly.
+              (split-window-sensibly window)))))
     (pop-to-buffer (get-buffer-create buf)))
   ;; If dired-shrink-to-fit is t, make its window fit its contents.
   (when dired-shrink-to-fit