[Emacs-diffs] /srv/bzr/emacs/trunk r100020: Close bug#5655.

[Glenn Morris]

------------------------------------------------------------
revno: 100020
committer: Glenn Morris <address@hidden>
branch nick: trunk
timestamp: Fri 2010-04-23 19:23:22 -0700
message:
  Close bug#5655.
  
  * configure.in (CRT_DIR): New output variable.
  (--with-crt-dir): New option.  (Bug#5655)
  (HAVE_LIB64_DIR): Remove.
  
  * src/Makefile.in (CRT_DIR): New variable, set by configure.
  * src/m/amdx86-64.h, m/ibms390x.h (START_FILES, LIB_STANDARD):
  Use $CRT_DIR rather than HAVE_LIB64_DIR.  (Bug#5655)
modified:
  ChangeLog
  configure.in
  src/ChangeLog
  src/Makefile.in
  src/m/ibms390x.h

=== modified file 'ChangeLog'
--- a/ChangeLog 2010-04-23 05:40:33 +0000
+++ b/ChangeLog 2010-04-24 02:23:22 +0000
@@ -1,3 +1,9 @@
+2010-04-24  Glenn Morris  <address@hidden>
+
+       * configure.in (CRT_DIR): New output variable.
+       (--with-crt-dir): New option.  (Bug#5655)
+       (HAVE_LIB64_DIR): Remove.
+
 2010-04-22  Dan Nicolaescu  <address@hidden>
 
        * configure.in (REAL_CFLAGS, CFLAGS): Restore -g for gcc.

=== modified file 'configure.in'
--- a/configure.in      2010-04-22 16:37:58 +0000
+++ b/configure.in      2010-04-24 02:23:22 +0000
@@ -186,6 +186,12 @@
    fi
 fi
 
+CRT_DIR=
+AC_ARG_WITH([crt-dir],dnl
+[AS_HELP_STRING([--with-crt-dir=DIR],[directory containing crtn.o etc.
+This option is only used on x86-64 and s390x GNU/Linux architectures.])])
+CRT_DIR="${with_crt_dir}"
+
 AC_ARG_WITH([gnustep-conf],dnl
 [AS_HELP_STRING([--with-gnustep-conf=PATH],[path to GNUstep.conf; default 
$GNUSTEP_CONFIG_FILE, or /etc/GNUstep/GNUstep.conf])])
 test "X${with_gnustep_conf}" != X && test "${with_gnustep_conf}" != yes && \
@@ -966,17 +972,31 @@
 AC_SYS_LARGEFILE
 
 
-### The standard library on x86-64 and s390x GNU/Linux distributions can
-### be located in either /usr/lib64 or /usr/lib.
-### In some rare cases, /usr/lib64 exists but does not contain the
-### relevant files (bug#1287).  Hence test for crtn.o.
+## Note: at present CRT_DIR is only used for amdx86-64 and ibms390x.
+## Other machine types hard-code the location in src/[ms]/*.h.
 case "${canonical}" in
   x86_64-*-linux-gnu* | s390x-*-linux-gnu* )
-    if test -e /usr/lib64/crtn.o; then
-      AC_DEFINE(HAVE_LIB64_DIR, 1,
-        [Define to 1 if the directory /usr/lib64 exists.])
-fi
+
+   ## On x86-64 and s390x GNU/Linux distributions, the standard library
+   ## can be in a variety of places.  We only try /usr/lib64 and /usr/lib.
+   ## For anything else (eg /usr/lib32), it is up the user to specify
+   ## the location (bug#5655).
+   ## Test for crtn.o, not just the directory, because sometimes the
+   ## directory exists but does not have the relevant files (bug#1287).
+   ## If user specified a crt-dir, use that unconditionally.
+   if test "X$CRT_DIR" = "X"; then
+     CRT_DIR=/usr/lib
+     test -e /usr/lib64/crtn.o && CRT_DIR=/usr/lib64
+   fi
+
+   test -e $CRT_DIR/crtn.o || test -e $CRT_DIR/crt0.o || \
+     AC_MSG_ERROR([crt*.o not found.  Use --with-crt-dir to specify the 
location.])
+   ;;
+
 esac
+test "X$CRT_DIR" = "X" && CRT_DIR=/usr/lib
+AC_SUBST(CRT_DIR)
+
 
 dnl This function defintion taken from Gnome 2.0
 dnl PKG_CHECK_MODULES(GSTUFF, gtk+-2.0 >= 1.3 glib = 1.3.4, action-if, 
action-not)

=== modified file 'src/ChangeLog'
--- a/src/ChangeLog     2010-04-23 22:28:10 +0000
+++ b/src/ChangeLog     2010-04-24 02:23:22 +0000
@@ -1,3 +1,9 @@
+2010-04-24  Glenn Morris  <address@hidden>
+
+       * Makefile.in (CRT_DIR): New variable, set by configure.
+       * m/amdx86-64.h, m/ibms390x.h (START_FILES, LIB_STANDARD):
+       Use $CRT_DIR rather than HAVE_LIB64_DIR.  (Bug#5655)
+
 2010-04-23  Dan Nicolaescu  <address@hidden>
 
        * Makefile.in: Remove C_SWITCH_X_MACHINE, unused.

=== modified file 'src/Makefile.in'
--- a/src/Makefile.in   2010-04-23 22:28:10 +0000
+++ b/src/Makefile.in   2010-04-24 02:23:22 +0000
@@ -68,6 +68,9 @@
 
 OTHER_FILES = @OTHER_FILES@
 
+## Only used by amdx86-64 and ibms390x GNU/Linux.
address@hidden@
+
 address@hidden@
 address@hidden@
 address@hidden@

=== modified file 'src/m/ibms390x.h'
--- a/src/m/ibms390x.h  2010-01-13 08:35:10 +0000
+++ b/src/m/ibms390x.h  2010-04-24 02:23:22 +0000
@@ -91,18 +91,10 @@
 #define XPNTR(a) XUINT (a)
 
 #undef START_FILES
-#ifdef HAVE_LIB64_DIR
-#define START_FILES pre-crt0.o /usr/lib64/crt1.o /usr/lib64/crti.o
-#else
-#define START_FILES pre-crt0.o /usr/lib/crt1.o /usr/lib/crti.o
-#endif
+#define START_FILES pre-crt0.o $(CRT_DIR)/crt1.o $(CRT_DIR)/crti.o
 
 #undef LIB_STANDARD
-#ifdef HAVE_LIB64_DIR
-#define LIB_STANDARD -lgcc -lc -lgcc /usr/lib64/crtn.o
-#else
-#define LIB_STANDARD -lgcc -lc -lgcc /usr/lib/crtn.o
-#endif
+#define LIB_STANDARD -lgcc -lc -lgcc $(CRT_DIR)/crtn.o
 
 /* arch-tag: 4b87653c-6add-4663-8691-7d9dc17b5519
    (do not change this comment) */