[Emacs-diffs] /srv/bzr/emacs/trunk r100431: Move some stuff from LD_SWITCH_SYSTEM to LD_SWITCH_SYSTEM_TEMACS.

[Glenn Morris]

------------------------------------------------------------
revno: 100431
committer: Glenn Morris <address@hidden>
branch nick: trunk
timestamp: Mon 2010-05-24 20:53:12 -0700
message:
  Move some stuff from LD_SWITCH_SYSTEM to LD_SWITCH_SYSTEM_TEMACS.
  
  * configure.in (LD_SWITCH_SYSTEM): Move some gnu-linux stuff...
  (LD_SWITCH_SYSTEM_TEMACS): ... to here.
  
  * src/Makefile.in (LD_SWITCH_SYSTEM_TEMACS): Move definition after some
  variables it may reference.
modified:
  ChangeLog
  configure.in
  src/ChangeLog
  src/Makefile.in

=== modified file 'ChangeLog'
--- a/ChangeLog 2010-05-25 03:46:15 +0000
+++ b/ChangeLog 2010-05-25 03:53:12 +0000
@@ -1,5 +1,8 @@
 2010-05-25  Glenn Morris  <address@hidden>
 
+       * configure.in (LD_SWITCH_SYSTEM): Move some gnu-linux stuff...
+       (LD_SWITCH_SYSTEM_TEMACS): ... to here.
+
        * configure.in (LD_SWITCH_SYSTEM_EXTRA): Remove.
        (LD_SWITCH_SYSTEM_TEMACS): Put darwin stuff from LD_SWITCH_SYSTEM_EXTRA
        here instead.

=== modified file 'configure.in'
--- a/configure.in      2010-05-25 03:46:15 +0000
+++ b/configure.in      2010-05-25 03:53:12 +0000
@@ -955,16 +955,17 @@
 
 ac_link="$ac_link $LD_SWITCH_SYSTEM"
 
-## This is fun.  Some settings of LD_SWITCH_SYSTEM reference
-## LD_SWITCH_X_SITE_AUX, which has not been defined yet.  When using
-## cpp, it was expanded to null.  Thus LD_SWITCH_SYSTEM had different
-## values in configure and the Makefiles.  How helpful.
-## FIXME why not use LD_SWITCH_SYSTEM_TEMACS (or somesuch) instead?
+## This setting of LD_SWITCH_SYSTEM references LD_SWITCH_X_SITE_AUX,
+## which has not been defined yet.  When this was handled with cpp,
+## it was expanded to null when configure sourced the s/*.h file.
+## Thus LD_SWITCH_SYSTEM had different values in configure and the Makefiles.
+## FIXME it would be cleaner to put this in LD_SWITCH_SYSTEM_TEMACS
+## (or somesuch), but because it is supposed to go at the _front_
+## of LD_SWITCH_SYSTEM, we cannot do that in exactly the same way.
+## Compare with the gnu-linux case below, which added to the end
+## of LD_SWITCH_SYSTEM, and so can instead go at the front of
+## LD_SWITCH_SYSTEM_TEMACS.
 case "$opsys" in
-  gnu-linux)
-   ## LD_SWITCH_X_SITE_AUX is a -R option saying where to find X at run-time.
-   LD_SWITCH_SYSTEM="$LD_SWITCH_SYSTEM \$(LD_SWITCH_X_SITE_AUX)" ;;
-
   netbsd|openbsd)
    ## _AUX_RPATH is like _AUX, but uses -rpath instead of -R.
    LD_SWITCH_SYSTEM="\$(LD_SWITCH_X_SITE_AUX_RPATH) $LD_SWITCH_SYSTEM" ;;
@@ -3272,33 +3273,41 @@
   aix4-2) LD_SWITCH_SYSTEM_TEMACS="-Wl,-bnodelcsect" ;;
 
   darwin)
-  ## The -headerpad option tells ld (see man page) to leave room at the
-  ## end of the header for adding load commands.  Needed for dumping.
-  ## 0x690 is the total size of 30 segment load commands (at 56
-  ## each); under Cocoa 31 commands are required.
-  if test "$HAVE_NS" = "yes"; then
-    libs_nsgui="-framework AppKit"
-    headerpad_extra=6C8
-  else
-    libs_nsgui=
-    headerpad_extra=690
-  fi
-  LD_SWITCH_SYSTEM_TEMACS="-prebind $libs_nsgui -Xlinker -headerpad -Xlinker 
$headerpad_extra"
+   ## The -headerpad option tells ld (see man page) to leave room at the
+   ## end of the header for adding load commands.  Needed for dumping.
+   ## 0x690 is the total size of 30 segment load commands (at 56
+   ## each); under Cocoa 31 commands are required.
+   if test "$HAVE_NS" = "yes"; then
+     libs_nsgui="-framework AppKit"
+     headerpad_extra=6C8
+   else
+     libs_nsgui=
+     headerpad_extra=690
+   fi
+   LD_SWITCH_SYSTEM_TEMACS="-prebind $libs_nsgui -Xlinker -headerpad -Xlinker 
$headerpad_extra"
+ 
+   ## This is here because src/Makefile.in did some extra fiddling around
+   ## with LD_SWITCH_SYSTEM.  The cpp logic was:
+   ##   #ifndef LD_SWITCH_SYSTEM
+   ##   #if !defined (__GNUC__) && ((defined (BSD_SYSTEM) && !defined (COFF)))
+   ## Since all the *bsds define LD_SWITCH_SYSTEM, this simplifies to:
+   ## not using gcc, darwin system not on an alpha (ie darwin, since
+   ## darwin + alpha does not occur).
+   ## Because this was done in src/Makefile.in, the resulting part of
+   ## LD_SWITCH_SYSTEM was not used in configure (ie, in ac_link).
+   ## It therefore seems cleaner to put this in LD_SWITCH_SYSTEM_TEMACS,
+   ## rather than LD_SWITCH_SYSTEM.
+   test "x$LD_SWITCH_SYSTEM" = "x" && test "x$GCC" != "xyes" && \
+     LD_SWITCH_SYSTEM_TEMACS="-X $LD_SWITCH_SYSTEM_TEMACS"
+   ;;
 
-  ## This is here because src/Makefile.in did some extra fiddling around
-  ## with LD_SWITCH_SYSTEM.  The cpp logic was:
-  ##   #ifndef LD_SWITCH_SYSTEM
-  ##   #if !defined (__GNUC__) && ((defined (BSD_SYSTEM) && !defined (COFF)))
-  ## Since all the *bsds define LD_SWITCH_SYSTEM, this simplifies to:
-  ## not using gcc, darwin system not on an alpha (ie darwin, since
-  ## darwin + alpha does not occur).
-  ## Because this was done in src/Makefile.in, the resulting part of
-  ## LD_SWITCH_SYSTEM was not used in configure (ie, in ac_link).
-  ## It therefore seems cleaner to put this in LD_SWITCH_SYSTEM_TEMACS,
-  ## rather than LD_SWITCH_SYSTEM.
-  test "x$LD_SWITCH_SYSTEM" = "x" && test "x$GCC" != "xyes" && \
-    LD_SWITCH_SYSTEM_TEMACS="-X $LD_SWITCH_SYSTEM_TEMACS"
-  ;;
+  ## LD_SWITCH_X_SITE_AUX is a -R option saying where to find X at run-time.
+  ## When handled by cpp, this was in LD_SWITCH_SYSTEM.  However, at
+  ## the point where configure sourced the s/*.h file, LD_SWITCH_X_SITE_AUX
+  ## had not yet been defined and was expanded to null.  Hence LD_SWITCH_SYSTEM
+  ## had different values in configure (in ac_link) and src/Makefile.in.
+  ## It seems clearer therefore to put this piece in LD_SWITCH_SYSTEM_TEMACS.
+  gnu-linux) LD_SWITCH_SYSTEM_TEMACS="\$(LD_SWITCH_X_SITE_AUX)" ;;
 
   *) LD_SWITCH_SYSTEM_TEMACS= ;;
 esac
@@ -3783,7 +3792,6 @@
 done
 
 # Build src/Makefile from ${srcdir}/src/Makefile.c
-# and lib-src/Makefile from ${srcdir}/lib-src/Makefile.c
 # This must be done after src/config.h is built, since we rely on that file.
 
 echo creating src/epaths.h

=== modified file 'src/ChangeLog'
--- a/src/ChangeLog     2010-05-25 03:46:15 +0000
+++ b/src/ChangeLog     2010-05-25 03:53:12 +0000
@@ -1,5 +1,8 @@
 2010-05-25  Glenn Morris  <address@hidden>
 
+       * Makefile.in (LD_SWITCH_SYSTEM_TEMACS): Move definition after some
+       variables it may reference.
+
        * Makefile.in (LD_SWITCH_SYSTEM_EXTRA): Remove.
        (TEMACS_LDFLAGS): Remove LD_SWITCH_SYSTEM_EXTRA.
 

=== modified file 'src/Makefile.in'
--- a/src/Makefile.in   2010-05-25 03:46:15 +0000
+++ b/src/Makefile.in   2010-05-25 03:53:12 +0000
@@ -96,12 +96,6 @@
 ## substituted in this or any other Makefile. Cf C_SWITCH_X_SITE.
 LD_SWITCH_X_SITE=
 
-## This holds any special options for linking temacs only (ie, not
-## used by configure).  Not used elsewhere because it sometimes
-## contains options that have to do with using Emacs's crt0, 
-## which are only good with temacs.
address@hidden@
-
 ## Next two must come before LD_SWITCH_SYSTEM.
 ## If needed, a -R option that says where to find X windows at run time.
 address@hidden@
@@ -111,6 +105,12 @@
 ## System-specific LDFLAGS.
 address@hidden@
 
+## This holds any special options for linking temacs only (ie, not
+## used by configure).  Not used elsewhere because it sometimes
+## contains options that have to do with using Emacs's crt0, 
+## which are only good with temacs.
address@hidden@
+
 ## Flags to pass to ld only for temacs.
 TEMACS_LDFLAGS = $(LD_SWITCH_SYSTEM) $(LD_SWITCH_SYSTEM_TEMACS)