[Emacs-diffs] /srv/bzr/emacs/emacs-23 r100041: * subr.el (unintern): Declare the obarray arg mandatory.

[Stefan Monnier]

------------------------------------------------------------
revno: 100041
committer: Stefan Monnier <address@hidden>
branch nick: emacs-23
timestamp: Tue 2010-09-14 13:11:44 +0200
message:
  * subr.el (unintern): Declare the obarray arg mandatory.
  * emacs-lisp/byte-run.el (set-advertised-calling-convention):
  Add `when' argument.  Update callers.
modified:
  etc/NEWS
  lisp/ChangeLog
  lisp/emacs-lisp/byte-run.el
  lisp/subr.el

=== modified file 'etc/NEWS'
--- a/etc/NEWS  2010-06-15 03:49:39 +0000
+++ b/etc/NEWS  2010-09-14 11:11:44 +0000
@@ -40,6 +40,8 @@
 
 * Lisp changes in Emacs 23.3
 
+** The use of unintern without an obarray arg is declared obsolete.
+
 ** New function byte-to-string, like char-to-string but for bytes.
 
 

=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog    2010-09-14 08:02:28 +0000
+++ b/lisp/ChangeLog    2010-09-14 11:11:44 +0000
@@ -1,3 +1,10 @@
+2010-09-14  Stefan Monnier  <address@hidden>
+
+       * emacs-lisp/byte-run.el (set-advertised-calling-convention):
+       Add `when' argument.  Update callers.
+
+       * subr.el (unintern): Declare the obarray arg mandatory.
+
 2010-09-14  Glenn Morris  <address@hidden>
 
        * calendar/diary-lib.el (diary-list-entries-hook, diary-sort-entries):

=== modified file 'lisp/emacs-lisp/byte-run.el'
--- a/lisp/emacs-lisp/byte-run.el       2010-01-13 08:35:10 +0000
+++ b/lisp/emacs-lisp/byte-run.el       2010-09-14 11:11:44 +0000
@@ -108,10 +108,11 @@
 
 (defvar advertised-signature-table (make-hash-table :test 'eq :weakness 'key))
 
-(defun set-advertised-calling-convention (function signature)
+(defun set-advertised-calling-convention (function signature when)
   "Set the advertised SIGNATURE of FUNCTION.
 This will allow the byte-compiler to warn the programmer when she uses
-an obsolete calling convention."
+an obsolete calling convention.  WHEN specifies since when the calling
+convention was modified."
   (puthash (indirect-function function) signature
            advertised-signature-table))
 
@@ -132,7 +133,7 @@
   obsolete-name)
 (set-advertised-calling-convention
  ;; New code should always provide the `when' argument.
- 'make-obsolete '(obsolete-name current-name when))
+ 'make-obsolete '(obsolete-name current-name when) "23.1")
 
 (defmacro define-obsolete-function-alias (obsolete-name current-name
                                                   &optional when docstring)
@@ -153,7 +154,7 @@
 (set-advertised-calling-convention
  ;; New code should always provide the `when' argument.
  'define-obsolete-function-alias
- '(obsolete-name current-name when &optional docstring))
+ '(obsolete-name current-name when &optional docstring) "23.1")
 
 (defun make-obsolete-variable (obsolete-name current-name &optional when)
   "Make the byte-compiler warn that OBSOLETE-NAME is obsolete.
@@ -175,7 +176,7 @@
   obsolete-name)
 (set-advertised-calling-convention
  ;; New code should always provide the `when' argument.
- 'make-obsolete-variable '(obsolete-name current-name when))
+ 'make-obsolete-variable '(obsolete-name current-name when) "23.1")
 
 (defmacro define-obsolete-variable-alias (obsolete-name current-name
                                                 &optional when docstring)
@@ -210,7 +211,7 @@
 (set-advertised-calling-convention
  ;; New code should always provide the `when' argument.
  'define-obsolete-variable-alias
- '(obsolete-name current-name when &optional docstring))
+ '(obsolete-name current-name when &optional docstring) "23.1")
 
 ;; FIXME This is only defined in this file because the variable- and
 ;; function- versions are too.  Unlike those two, this one is not used

=== modified file 'lisp/subr.el'
--- a/lisp/subr.el      2010-08-21 08:56:54 +0000
+++ b/lisp/subr.el      2010-09-14 11:11:44 +0000
@@ -238,7 +238,7 @@
 for the sake of consistency."
   (while t
     (signal 'error (list (apply 'format args)))))
-(set-advertised-calling-convention 'error '(string &rest args))
+(set-advertised-calling-convention 'error '(string &rest args) "23.1")
 
 ;; We put this here instead of in frame.el so that it's defined even on
 ;; systems where frame.el isn't loaded.
@@ -1038,9 +1038,10 @@
 (make-obsolete 'make-variable-frame-local
               "explicitly check for a frame-parameter instead." "22.2")
 (make-obsolete 'interactive-p 'called-interactively-p "23.2")
-(set-advertised-calling-convention 'called-interactively-p '(kind))
+(set-advertised-calling-convention 'called-interactively-p '(kind) "23.1")
 (set-advertised-calling-convention
- 'all-completions '(string collection &optional predicate))
+ 'all-completions '(string collection &optional predicate) "23.1")
+(set-advertised-calling-convention 'unintern '(name obarray) "23.3")
 
 ;;;; Obsolescence declarations for variables, and aliases.
 
@@ -2061,7 +2062,7 @@
                (setq read (cons t read)))
            (push read unread-command-events)
            nil))))))
-(set-advertised-calling-convention 'sit-for '(seconds &optional nodisp))
+(set-advertised-calling-convention 'sit-for '(seconds &optional nodisp) "22.1")
 
 ;;; Atomic change groups.
 
@@ -2589,7 +2590,7 @@
   (start-process name buffer shell-file-name shell-command-switch
                 (mapconcat 'identity args " ")))
 (set-advertised-calling-convention 'start-process-shell-command
-                                   '(name buffer command))
+                                   '(name buffer command) "23.1")
 
 (defun start-file-process-shell-command (name buffer &rest args)
   "Start a program in a subprocess.  Return the process object for it.
@@ -2600,7 +2601,7 @@
    (if (file-remote-p default-directory) "-c" shell-command-switch)
    (mapconcat 'identity args " ")))
 (set-advertised-calling-convention 'start-file-process-shell-command
-                                   '(name buffer command))
+                                   '(name buffer command) "23.1")
 
 (defun call-process-shell-command (command &optional infile buffer display
                                           &rest args)