emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] /srv/bzr/emacs/emacs-23 r100120: Don't allow functions tha


From: Chong Yidong
Subject: [Emacs-diffs] /srv/bzr/emacs/emacs-23 r100120: Don't allow functions that display messages in unsafep.
Date: Mon, 18 Oct 2010 13:28:20 -0400
User-agent: Bazaar (2.0.3)

------------------------------------------------------------
revno: 100120
committer: Chong Yidong <address@hidden>
branch nick: emacs-23
timestamp: Mon 2010-10-18 13:28:20 -0400
message:
  Don't allow functions that display messages in unsafep.
  
  * emacs-lisp/unsafep.el: Don't mark functions that display
  messages as safe.  Suggested by Johan Bockgård.
modified:
  lisp/ChangeLog
  lisp/emacs-lisp/unsafep.el
=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog    2010-10-17 17:30:22 +0000
+++ b/lisp/ChangeLog    2010-10-18 17:28:20 +0000
@@ -1,3 +1,8 @@
+2010-10-18  Chong Yidong  <address@hidden>
+
+       * emacs-lisp/unsafep.el: Don't mark functions that display
+       messages as safe.  Suggested by Johan Bockgård.
+
 2010-10-17  Stefan Monnier  <address@hidden>
 
        * minibuffer.el (completion--replace): Move point where it belongs

=== modified file 'lisp/emacs-lisp/unsafep.el'
--- a/lisp/emacs-lisp/unsafep.el        2010-01-13 08:35:10 +0000
+++ b/lisp/emacs-lisp/unsafep.el        2010-10-18 17:28:20 +0000
@@ -101,15 +101,13 @@
 (dolist (x '(;;Special forms
             and catch if or prog1 prog2 progn while unwind-protect
             ;;Safe subrs that have some side-effects
-            ding error message minibuffer-message random read-minibuffer
-            signal sleep-for string-match throw y-or-n-p yes-or-no-p
+            ding error random signal sleep-for string-match throw
             ;;Defsubst functions from subr.el
             caar cadr cdar cddr
             ;;Macros from subr.el
-            save-match-data unless when with-temp-message
+            save-match-data unless when
             ;;Functions from subr.el that have side effects
-            read-passwd split-string replace-regexp-in-string
-            play-sound-file))
+            split-string replace-regexp-in-string play-sound-file))
   (put x 'safe-function t))
 
 ;;;###autoload


reply via email to

[Prev in Thread] Current Thread [Next in Thread]