[Emacs-diffs] /srv/bzr/emacs/trunk r103983: Delete char-direction-table and char-direction.

[Eli Zaretskii]

------------------------------------------------------------
revno: 103983
committer: Eli Zaretskii <address@hidden>
branch nick: trunk
timestamp: Sun 2011-04-24 10:11:56 +0300
message:
  Delete char-direction-table and char-direction.
  
   See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00675.html
   for the reasons.
  
   src/character.c (Fchar_direction): Function deleted.
   (syms_of_character): Don't defsubr it.
   <char-direction-table>: Deleted.
   etc/NEWS: Document the removal.
modified:
  etc/NEWS
  src/ChangeLog
  src/character.c

=== modified file 'etc/NEWS'
--- a/etc/NEWS  2011-04-20 22:31:06 +0000
+++ b/etc/NEWS  2011-04-24 07:11:56 +0000
@@ -134,7 +134,7 @@
 libraries if they are present at build time.  This needs ImageMagick
 6.2.8 or newer (versions newer than 6.0.7 _may_ work but have not been
 tested).  To disable ImageMagick support, use the configure option
-`--without-imagemagick'.  
+`--without-imagemagick'.
 
 The new function `imagemagick-types' returns a list of image file
 extensions that your installation of ImageMagick supports.  The
@@ -720,6 +720,13 @@
 
 * Incompatible Lisp Changes in Emacs 24.1
 
+---
+** `char-direction-table' and the associated function `char-direction'
+were deleted.  They were buggy and inferior to the new support of
+bidirectional editing introduced in Emacs 24.  If you need the
+bidirectional properties of a character, use `get-char-code-property'
+with the last argument `bidi-class'.
+
 ** `copy-directory' now copies the source directory as a subdirectory
 of the target directory, if the latter is an existing directory.  The
 new optional arg COPY-CONTENTS, if non-nil, makes the function copy

=== modified file 'src/ChangeLog'
--- a/src/ChangeLog     2011-04-23 10:33:28 +0000
+++ b/src/ChangeLog     2011-04-24 07:11:56 +0000
@@ -1,3 +1,9 @@
+2011-04-24  Eli Zaretskii  <address@hidden>
+
+       * character.c (Fchar_direction): Function deleted.
+       (syms_of_character): Don't defsubr it.
+       <char-direction-table>: Deleted.
+
 2011-04-23  Eli Zaretskii  <address@hidden>
 
        Fix doprnt so it could be used again safely in `verror'.  (Bug#8435)

=== modified file 'src/character.c'
--- a/src/character.c   2011-04-23 17:19:56 +0000
+++ b/src/character.c   2011-04-24 07:11:56 +0000
@@ -493,19 +493,6 @@
   return val;
 }
 
-DEFUN ("char-direction", Fchar_direction, Schar_direction, 1, 1, 0,
-       doc: /* Return the direction of CHAR.
-The returned value is 0 for left-to-right and 1 for right-to-left.
-usage: (char-direction CHAR)  */)
-  (Lisp_Object ch)
-{
-  int c;
-
-  CHECK_CHARACTER (ch);
-  c = XINT (ch);
-  return CHAR_TABLE_REF (Vchar_direction_table, c);
-}
-
 /* Return the number of characters in the NBYTES bytes at PTR.
    This works by looking at the contents and checking for multibyte
    sequences while assuming that there's no invalid sequence.
@@ -1037,7 +1024,6 @@
   defsubr (&Smultibyte_char_to_unibyte);
   defsubr (&Schar_width);
   defsubr (&Sstring_width);
-  defsubr (&Schar_direction);
   defsubr (&Sstring);
   defsubr (&Sunibyte_string);
   defsubr (&Schar_resolve_modifiers);
@@ -1066,10 +1052,6 @@
   char_table_set_range (Vchar_width_table, MAX_5_BYTE_CHAR + 1, MAX_CHAR,
                        make_number (4));
 
-  DEFVAR_LISP ("char-direction-table", Vchar_direction_table,
-              doc: /* A char-table for direction of each character.  */);
-  Vchar_direction_table = Fmake_char_table (Qnil, make_number (1));
-
   DEFVAR_LISP ("printable-chars", Vprintable_chars,
               doc: /* A char-table for each printable character.  */);
   Vprintable_chars = Fmake_char_table (Qnil, Qnil);