Re: [Emacs-diffs] /srv/bzr/emacs/trunk r107186: In server-unselect-display make sure that buffer is live before killing it

[Stefan Monnier]

>   In server-unselect-display make sure that buffer is live before killing it

Is it just for "defensive coding" reasons, or are there actual cases
where this buffer could be dead?

>      (let ((buffer (frame-parameter frame 'server-dummy-buffer)))
> -      (if (and (one-window-p 'nomini frame)
> -            (eq (window-buffer (frame-first-window frame)) buffer))
> -       ;; The temp frame still only shows one buffer, and that is the
> -       ;; internal temp buffer.
> -       (delete-frame frame)
> -     (set-frame-parameter frame 'visibility t)
> -     (set-frame-parameter frame 'server-dummy-buffer nil))
> -      (kill-buffer buffer))))
> +      (when (buffer-live-p buffer)
> +     (if (and (one-window-p 'nomini frame)
> +              (eq (window-buffer (frame-first-window frame)) buffer))
> +         ;; The temp frame still only shows one buffer, and that is the
> +         ;; internal temp buffer.
> +         (delete-frame frame)
> +       (set-frame-parameter frame 'visibility t)
> +       (set-frame-parameter frame 'server-dummy-buffer nil))
> +     (kill-buffer buffer)))))
 
Why should the frame not be deleted when the buffer is dead?
Shouldn't the "(when (buffer-live-p buffer)" test only protect the call
to kill-buffer?


        Stefan