[Emacs-diffs] /srv/bzr/emacs/trunk r109574: * lisp/ibuffer.el (ibuffer-do-toggle-read-only):

[Stefan Monnier]

------------------------------------------------------------
revno: 109574
committer: Stefan Monnier <address@hidden>
branch nick: trunk
timestamp: Sun 2012-08-12 13:29:53 -0400
message:
  * lisp/ibuffer.el (ibuffer-do-toggle-read-only):
  * lisp/dired.el (dired-toggle-read-only):
  * lisp/buff-menu.el (Buffer-menu-toggle-read-only):
  * lisp/bindings.el (mode-line-toggle-read-only):
  * lisp/bs.el (bs-toggle-readonly): Call toggle-read-only interactively.
modified:
  lisp/ChangeLog
  lisp/bindings.el
  lisp/bs.el
  lisp/buff-menu.el
  lisp/dired.el
  lisp/ibuffer.el

=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog    2012-08-12 09:35:57 +0000
+++ b/lisp/ChangeLog    2012-08-12 17:29:53 +0000
@@ -1,3 +1,11 @@
+2012-08-12  Stefan Monnier  <address@hidden>
+
+       * ibuffer.el (ibuffer-do-toggle-read-only):
+       * dired.el (dired-toggle-read-only):
+       * buff-menu.el (Buffer-menu-toggle-read-only):
+       * bindings.el (mode-line-toggle-read-only):
+       * bs.el (bs-toggle-readonly): Call toggle-read-only interactively.
+
 2012-08-12  Andreas Schwab  <address@hidden>
 
        * descr-text.el (describe-char): Put the overlays over the

=== modified file 'lisp/bindings.el'
--- a/lisp/bindings.el  2012-08-10 16:02:48 +0000
+++ b/lisp/bindings.el  2012-08-12 17:29:53 +0000
@@ -40,8 +40,7 @@
   (interactive "e")
   (save-selected-window
     (select-window (posn-window (event-start event)))
-    (toggle-read-only nil t)
-    (force-mode-line-update)))
+    (call-interactively 'toggle-read-only)))
 
 (defun mode-line-toggle-modified (event)
   "Toggle the buffer-modified flag from the mode-line."

=== modified file 'lisp/bs.el'
--- a/lisp/bs.el        2012-07-13 07:06:09 +0000
+++ b/lisp/bs.el        2012-08-12 17:29:53 +0000
@@ -962,7 +962,7 @@
 Uses function `toggle-read-only'."
   (interactive)
   (with-current-buffer (bs--current-buffer)
-    (toggle-read-only))
+    (call-interactively 'toggle-read-only))
   (bs--update-current-line))
 
 (defun bs-clear-modified ()

=== modified file 'lisp/buff-menu.el'
--- a/lisp/buff-menu.el 2012-07-31 22:34:36 +0000
+++ b/lisp/buff-menu.el 2012-08-12 17:29:53 +0000
@@ -518,10 +518,10 @@
   "Toggle read-only status of buffer on this line.
 This behaves like invoking \\[toggle-read-only] in that buffer."
   (interactive)
-  (let (read-only)
-    (with-current-buffer (Buffer-menu-buffer t)
-      (toggle-read-only)
-      (setq read-only buffer-read-only))
+  (let ((read-only
+         (with-current-buffer (Buffer-menu-buffer t)
+           (call-interactively 'toggle-read-only)
+           buffer-read-only)))
     (tabulated-list-set-col 1 (if read-only "%" " ") t)))
 
 (defun Buffer-menu-bury ()

=== modified file 'lisp/dired.el'
--- a/lisp/dired.el     2012-07-18 09:27:23 +0000
+++ b/lisp/dired.el     2012-08-12 17:29:53 +0000
@@ -1961,9 +1961,9 @@
 mode is `dired-mode'), call `wdired-change-to-wdired-mode'.
 Otherwise, call `toggle-read-only'."
   (interactive)
-  (if (eq major-mode 'dired-mode)
+  (if (derived-mode-p 'dired-mode)
       (wdired-change-to-wdired-mode)
-    (toggle-read-only nil t)))
+    (call-interactively 'toggle-read-only)))
 
 (defun dired-next-line (arg)
   "Move down lines then position at filename.

=== modified file 'lisp/ibuffer.el'
--- a/lisp/ibuffer.el   2012-07-13 07:06:09 +0000
+++ b/lisp/ibuffer.el   2012-08-12 17:29:53 +0000
@@ -1279,11 +1279,11 @@
 
 (define-ibuffer-op ibuffer-do-toggle-read-only (&optional arg)
   "Toggle read only status in marked buffers.
-With optional ARG, make read-only only if ARG is positive."
+With optional ARG, make read-only only if ARG is not negative."
   (:opstring "toggled read only status in"
    :interactive "P"
    :modifier-p t)
-  (toggle-read-only arg t))
+  (call-interactively 'toggle-read-only))
 
 (define-ibuffer-op ibuffer-do-delete ()
   "Kill marked buffers as with `kill-this-buffer'."