[Emacs-diffs] /srv/bzr/emacs/trunk r109693: Inline setter functions for hash table members.

[Dmitry Antipov]

------------------------------------------------------------
revno: 109693
committer: Dmitry Antipov <address@hidden>
branch nick: trunk
timestamp: Mon 2012-08-20 12:07:38 +0400
message:
  Inline setter functions for hash table members.
  * lisp.h (set_hash_key, set_hash_value, set_hash_next)
  (set_hash_hash, set_hash_index): Rename with _slot suffix.
  (set_hash_key_and_value, set_hash_index, set_hash_next)
  (set_hash_hash): New functions.
  * charset.c, fns.c: Adjust users.
modified:
  src/ChangeLog
  src/charset.c
  src/fns.c
  src/lisp.h

=== modified file 'src/ChangeLog'
--- a/src/ChangeLog     2012-08-20 07:42:06 +0000
+++ b/src/ChangeLog     2012-08-20 08:07:38 +0000
@@ -1,5 +1,14 @@
 2012-08-20  Dmitry Antipov  <address@hidden>
 
+       Inline setter functions for hash table members.
+       * lisp.h (set_hash_key, set_hash_value, set_hash_next)
+       (set_hash_hash, set_hash_index): Rename with _slot suffix.
+       (set_hash_key_and_value, set_hash_index, set_hash_next)
+       (set_hash_hash): New functions.
+       * charset.c, fns.c: Adjust users.
+
+2012-08-20  Dmitry Antipov  <address@hidden>
+
        Inline getter and setter functions for per-buffer values.
        * buffer.h (per_buffer_default, set_per_buffer_default)
        (per_buffer_value, set_per_buffer_value): New functions.

=== modified file 'src/charset.c'
--- a/src/charset.c     2012-08-16 21:58:44 +0000
+++ b/src/charset.c     2012-08-20 08:07:38 +0000
@@ -1131,7 +1131,7 @@
     {
       new_definition_p = 0;
       id = XFASTINT (CHARSET_SYMBOL_ID (args[charset_arg_name]));
-      set_hash_value (hash_table, charset.hash_index, attrs);
+      set_hash_value_slot (hash_table, charset.hash_index, attrs);
     }
   else
     {

=== modified file 'src/fns.c'
--- a/src/fns.c 2012-08-17 21:12:11 +0000
+++ b/src/fns.c 2012-08-20 08:07:38 +0000
@@ -3663,7 +3663,7 @@
 
   /* Set up the free list.  */
   for (i = 0; i < sz - 1; ++i)
-    set_hash_next (h, i, make_number (i + 1));
+    set_hash_next_slot (h, i, make_number (i + 1));
   h->next_free = make_number (0);
 
   XSET_HASH_TABLE (table, h);
@@ -3760,17 +3760,17 @@
        }
 #endif
 
-      h->key_and_value = larger_vector (h->key_and_value,
-                                       2 * (new_size - old_size), -1);
-      h->next = larger_vector (h->next, new_size - old_size, -1);
-      h->hash = larger_vector (h->hash, new_size - old_size, -1);
-      h->index = Fmake_vector (make_number (index_size), Qnil);
+      set_hash_key_and_value (h, larger_vector (h->key_and_value,
+                                               2 * (new_size - old_size), -1));
+      set_hash_next (h, larger_vector (h->next, new_size - old_size, -1));
+      set_hash_hash (h, larger_vector (h->hash, new_size - old_size, -1));
+      set_hash_index (h, Fmake_vector (make_number (index_size), Qnil));
 
       /* Update the free list.  Do it so that new entries are added at
          the end of the free list.  This makes some operations like
          maphash faster.  */
       for (i = old_size; i < new_size - 1; ++i)
-       set_hash_next (h, i, make_number (i + 1));
+       set_hash_next_slot (h, i, make_number (i + 1));
 
       if (!NILP (h->next_free))
        {
@@ -3781,7 +3781,7 @@
                 !NILP (next))
            last = next;
 
-         set_hash_next (h, XFASTINT (last), make_number (old_size));
+         set_hash_next_slot (h, XFASTINT (last), make_number (old_size));
        }
       else
        XSETFASTINT (h->next_free, old_size);
@@ -3792,8 +3792,8 @@
          {
            EMACS_UINT hash_code = XUINT (HASH_HASH (h, i));
            ptrdiff_t start_of_bucket = hash_code % ASIZE (h->index);
-           set_hash_next (h, i, HASH_INDEX (h, start_of_bucket));
-           set_hash_index (h, start_of_bucket, make_number (i));
+           set_hash_next_slot (h, i, HASH_INDEX (h, start_of_bucket));
+           set_hash_index_slot (h, start_of_bucket, make_number (i));
          }
     }
 }
@@ -3852,16 +3852,16 @@
   /* Store key/value in the key_and_value vector.  */
   i = XFASTINT (h->next_free);
   h->next_free = HASH_NEXT (h, i);
-  set_hash_key (h, i, key);
-  set_hash_value (h, i, value);
+  set_hash_key_slot (h, i, key);
+  set_hash_value_slot (h, i, value);
 
   /* Remember its hash code.  */
-  set_hash_hash (h, i, make_number (hash));
+  set_hash_hash_slot (h, i, make_number (hash));
 
   /* Add new entry to its collision chain.  */
   start_of_bucket = hash % ASIZE (h->index);
-  set_hash_next (h, i, HASH_INDEX (h, start_of_bucket));
-  set_hash_index (h, start_of_bucket, make_number (i));
+  set_hash_next_slot (h, i, HASH_INDEX (h, start_of_bucket));
+  set_hash_index_slot (h, start_of_bucket, make_number (i));
   return i;
 }
 
@@ -3892,16 +3892,16 @@
        {
          /* Take entry out of collision chain.  */
          if (NILP (prev))
-           set_hash_index (h, start_of_bucket, HASH_NEXT (h, i));
+           set_hash_index_slot (h, start_of_bucket, HASH_NEXT (h, i));
          else
-           set_hash_next (h, XFASTINT (prev), HASH_NEXT (h, i));
+           set_hash_next_slot (h, XFASTINT (prev), HASH_NEXT (h, i));
 
          /* Clear slots in key_and_value and add the slots to
             the free list.  */
-         set_hash_key (h, i, Qnil);
-         set_hash_value (h, i, Qnil);
-         set_hash_hash (h, i, Qnil);
-         set_hash_next (h, i, h->next_free);
+         set_hash_key_slot (h, i, Qnil);
+         set_hash_value_slot (h, i, Qnil);
+         set_hash_hash_slot (h, i, Qnil);
+         set_hash_next_slot (h, i, h->next_free);
          h->next_free = make_number (i);
          h->count--;
          eassert (h->count >= 0);
@@ -3927,10 +3927,10 @@
 
       for (i = 0; i < size; ++i)
        {
-         set_hash_next (h, i, i < size - 1 ? make_number (i + 1) : Qnil);
-         set_hash_key (h, i, Qnil);
-         set_hash_value (h, i, Qnil);
-         set_hash_hash (h, i, Qnil);
+         set_hash_next_slot (h, i, i < size - 1 ? make_number (i + 1) : Qnil);
+         set_hash_key_slot (h, i, Qnil);
+         set_hash_value_slot (h, i, Qnil);
+         set_hash_hash_slot (h, i, Qnil);
        }
 
       for (i = 0; i < ASIZE (h->index); ++i)
@@ -3994,18 +3994,18 @@
                {
                  /* Take out of collision chain.  */
                  if (NILP (prev))
-                   set_hash_index (h, bucket, next);
+                   set_hash_index_slot (h, bucket, next);
                  else
-                   set_hash_next (h, XFASTINT (prev), next);
+                   set_hash_next_slot (h, XFASTINT (prev), next);
 
                  /* Add to free list.  */
-                 set_hash_next (h, i, h->next_free);
+                 set_hash_next_slot (h, i, h->next_free);
                  h->next_free = idx;
 
                  /* Clear key, value, and hash.  */
-                 set_hash_key (h, i, Qnil);
-                 set_hash_value (h, i, Qnil);
-                 set_hash_hash (h, i, Qnil);
+                 set_hash_key_slot (h, i, Qnil);
+                 set_hash_value_slot (h, i, Qnil);
+                 set_hash_hash_slot (h, i, Qnil);
 
                  h->count--;
                }
@@ -4512,7 +4512,7 @@
 
   i = hash_lookup (h, key, &hash);
   if (i >= 0)
-    set_hash_value (h, i, value);
+    set_hash_value_slot (h, i, value);
   else
     hash_put (h, key, value, hash);
 

=== modified file 'src/lisp.h'
--- a/src/lisp.h        2012-08-18 23:53:43 +0000
+++ b/src/lisp.h        2012-08-20 08:07:38 +0000
@@ -2345,31 +2345,55 @@
 }
 
 LISP_INLINE void
-set_hash_key (struct Lisp_Hash_Table *h, ptrdiff_t idx, Lisp_Object val)
+set_hash_key_and_value (struct Lisp_Hash_Table *h, Lisp_Object key_and_value)
+{
+  h->key_and_value = key_and_value;
+}
+
+LISP_INLINE void
+set_hash_key_slot (struct Lisp_Hash_Table *h, ptrdiff_t idx, Lisp_Object val)
 {
   gc_aset (h->key_and_value, 2 * idx, val);
 }
 
 LISP_INLINE void
-set_hash_value (struct Lisp_Hash_Table *h, ptrdiff_t idx, Lisp_Object val)
+set_hash_value_slot (struct Lisp_Hash_Table *h, ptrdiff_t idx, Lisp_Object val)
 {
   gc_aset (h->key_and_value, 2 * idx + 1, val);
 }
 
 LISP_INLINE void
-set_hash_next (struct Lisp_Hash_Table *h, ptrdiff_t idx, Lisp_Object val)
+set_hash_next (struct Lisp_Hash_Table *h, Lisp_Object next)
+{
+  h->next = next;
+}
+
+LISP_INLINE void
+set_hash_next_slot (struct Lisp_Hash_Table *h, ptrdiff_t idx, Lisp_Object val)
 {
   gc_aset (h->next, idx, val);
 }
 
 LISP_INLINE void
-set_hash_hash (struct Lisp_Hash_Table *h, ptrdiff_t idx, Lisp_Object val)
+set_hash_hash (struct Lisp_Hash_Table *h, Lisp_Object hash)
+{
+  h->hash = hash;
+}
+
+LISP_INLINE void
+set_hash_hash_slot (struct Lisp_Hash_Table *h, ptrdiff_t idx, Lisp_Object val)
 {
   gc_aset (h->hash, idx, val);
 }
 
 LISP_INLINE void
-set_hash_index (struct Lisp_Hash_Table *h, ptrdiff_t idx, Lisp_Object val)
+set_hash_index (struct Lisp_Hash_Table *h, Lisp_Object index)
+{
+  h->index = index;
+}
+
+LISP_INLINE void
+set_hash_index_slot (struct Lisp_Hash_Table *h, ptrdiff_t idx, Lisp_Object val)
 {
   gc_aset (h->index, idx, val);
 }