[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109810: * eshell/esh-ext.el (esh
From: |
Michael Albinus |
Subject: |
Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109810: * eshell/esh-ext.el (eshell-external-command): Do not examine |
Date: |
Wed, 29 Aug 2012 19:40:39 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) |
Stefan Monnier <address@hidden> writes:
>> + (let ((interp (eshell-find-interpreter
>> + command
>> + ;; Do not examine remote shell scripts.
>> + (or (and (stringp command) (file-remote-p command))
>> + (file-remote-p default-directory)))))
>
> I think that most uses of file-remote-p are wrong (in the sense that,
> while they may return an info that's correlated with the one we need,
> it's not exactly what we need) and this one is no exception.
> So I think in the above case it'd be better to use something along the
> lines of `ignore-errors'.
We have different interpretation of `file-remote-p', yes.
But in this given case, I do not understand what you mean with "along
the lines of `ignore-errors'". If I understand correctly the reported
error, we must suppress eshell's feature to look for the shell
interpreter in files located on a remote host. How shall I implement
this with the help of `ignore-error'?
> Stefan
Best regards, Michael.