[Emacs-diffs] /srv/bzr/emacs/trunk r109998: Remove unread-command-char.

[Stefan Monnier]

------------------------------------------------------------
revno: 109998
committer: Stefan Monnier <address@hidden>
branch nick: trunk
timestamp: Wed 2012-09-12 15:16:36 -0400
message:
  Remove unread-command-char.
  * src/keyboard.c (read_char, requeued_events_pending_p, Finput_pending_p)
  (Fdiscard_input, quit_throw_to_read_char, init_keyboard)
  (syms_of_keyboard): Remove support for unread-command-char.
  * lisp/emacs-lisp/debug.el (debugger-outer-unread-command-char, debug)
  (debugger-env-macro): Remove support for unread-command-char.
  
  * lisp/ehelp.el (with-electric-help): Accept functions in
  electric-help-form-to-execute.
  (electric-help-execute-extended, electric-help-ctrl-x-prefix): Use it.
  And replace unread-command-char -> unread-command-events.
  
  * lisp/subr.el (set-temporary-overlay-map): Minimize slightly the impact of
  the temporary map re-appearing on emulation-mode-map-alists.
  
  * lisp/emacs-lisp/edebug.el (def-edebug-form-spec): Remove, it's been broken
  since 22.1.
modified:
  doc/lispref/commands.texi
  etc/NEWS
  lisp/ChangeLog
  lisp/ehelp.el
  lisp/emacs-lisp/debug.el
  lisp/emacs-lisp/edebug.el
  lisp/progmodes/ebrowse.el
  lisp/subr.el
  src/ChangeLog
  src/data.c
  src/keyboard.c

=== modified file 'doc/lispref/commands.texi'
--- a/doc/lispref/commands.texi 2012-07-21 14:48:17 +0000
+++ b/doc/lispref/commands.texi 2012-09-12 19:16:36 +0000
@@ -2738,17 +2738,6 @@
 individual events, which you can put in @code{unread-command-events}.
 @end defun
 
address@hidden
address@hidden unread-command-char
-This variable holds a character to be read as command input.
-A value of -1 means ``empty''.
-
-This variable is mostly obsolete now that you can use
address@hidden instead; it exists only to support programs
-written for Emacs versions 18 and earlier.
address@hidden defvar
address@hidden ignore
-
 @defun input-pending-p
 @cindex waiting for command key input
 This function determines whether any command input is currently

=== modified file 'etc/NEWS'
--- a/etc/NEWS  2012-09-12 00:14:50 +0000
+++ b/etc/NEWS  2012-09-12 19:16:36 +0000
@@ -638,7 +638,7 @@
 
 *** `facemenu-unlisted-faces'
 *** `rmail-decode-mime-charset'
-*** `last-input-char' and `last-command-char'
+*** `last-input-char', `last-command-char', `unread-command-char'.
 
 
 * Lisp changes in Emacs 24.3

=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog    2012-09-12 16:36:25 +0000
+++ b/lisp/ChangeLog    2012-09-12 19:16:36 +0000
@@ -1,3 +1,19 @@
+2012-09-12  Stefan Monnier  <address@hidden>
+
+       * emacs-lisp/debug.el (debugger-outer-unread-command-char, debug)
+       (debugger-env-macro): Remove support for unread-command-char.
+
+       * subr.el (set-temporary-overlay-map): Minimize slightly the impact of
+       the temporary map re-appearing on emulation-mode-map-alists.
+
+       * emacs-lisp/edebug.el (def-edebug-form-spec): Remove, it's been broken
+       since 22.1.
+
+       * ehelp.el (with-electric-help): Accept functions in
+       electric-help-form-to-execute.
+       (electric-help-execute-extended, electric-help-ctrl-x-prefix): Use it.
+       And replace unread-command-char -> unread-command-events.
+
 2012-09-12  Michael Albinus  <address@hidden>
 
        Sync with Tramp 2.2.6.
@@ -9,8 +25,8 @@
 
 2012-09-12  Martin Rudalics  <address@hidden>
 
-       * emacs-lisp/debug.el (debugger-previous-window-height): New
-       variable.
+       * emacs-lisp/debug.el (debugger-previous-window-height):
+       New variable.
        (debug): When debugger-jumping-flag is non-nil try to restore
        height of debugger window.  (Bug#8789)
 

=== modified file 'lisp/ehelp.el'
--- a/lisp/ehelp.el     2012-01-19 07:21:25 +0000
+++ b/lisp/ehelp.el     2012-09-12 19:16:36 +0000
@@ -193,7 +193,9 @@
        (replace-buffer-in-windows buffer)
        ;; must do this outside of save-window-excursion
        (bury-buffer buffer))
-      (eval electric-help-form-to-execute))))
+      (if (functionp electric-help-form-to-execute)
+          (funcall electric-help-form-to-execute)
+        (eval electric-help-form-to-execute)))))
 
 (defun electric-help-command-loop ()
   (catch 'exit
@@ -349,14 +351,19 @@
 ;; continues with execute-extended-command.
 (defun electric-help-execute-extended (_prefixarg)
   (interactive "p")
-  (setq electric-help-form-to-execute '(execute-extended-command nil))
+  (setq electric-help-form-to-execute
+        (lambda () (execute-extended-command nil)))
   (electric-help-retain))
 
 ;; This is to be buond to C-x in ehelp mode. Retains ehelp buffer and then
 ;; continues with ctrl-x prefix.
 (defun electric-help-ctrl-x-prefix (_prefixarg)
   (interactive "p")
-  (setq electric-help-form-to-execute '(progn (message nil) (setq 
unread-command-char ?\C-x)))
+  (setq electric-help-form-to-execute
+        (lambda ()
+          (message nil)
+          (setq unread-command-events
+                (append unread-command-events '(?\C-x)))))
   (electric-help-retain))
 
 

=== modified file 'lisp/emacs-lisp/debug.el'
--- a/lisp/emacs-lisp/debug.el  2012-09-12 15:49:17 +0000
+++ b/lisp/emacs-lisp/debug.el  2012-09-12 19:16:36 +0000
@@ -110,10 +110,6 @@
 (defvar debugger-outer-track-mouse)
 (defvar debugger-outer-last-command)
 (defvar debugger-outer-this-command)
-;; unread-command-char is obsolete,
-;; but we still save and restore it
-;; in case some user program still tries to set it.
-(defvar debugger-outer-unread-command-char)
 (defvar debugger-outer-unread-command-events)
 (defvar debugger-outer-unread-post-input-method-events)
 (defvar debugger-outer-last-input-event)
@@ -185,8 +181,6 @@
          (debugger-outer-track-mouse track-mouse)
          (debugger-outer-last-command last-command)
          (debugger-outer-this-command this-command)
-         (debugger-outer-unread-command-char
-          (with-no-warnings unread-command-char))
          (debugger-outer-unread-command-events unread-command-events)
          (debugger-outer-unread-post-input-method-events
           unread-post-input-method-events)
@@ -221,8 +215,6 @@
            (cursor-in-echo-area nil))
        (unwind-protect
            (save-excursion
-             (with-no-warnings
-               (setq unread-command-char -1))
              (when (eq (car debugger-args) 'debug)
                ;; Skip the frames for backtrace-debug, byte-code,
                ;; and implement-debug-on-entry.
@@ -302,8 +294,6 @@
       (setq track-mouse debugger-outer-track-mouse)
       (setq last-command debugger-outer-last-command)
       (setq this-command debugger-outer-this-command)
-      (with-no-warnings
-       (setq unread-command-char debugger-outer-unread-command-char))
       (setq unread-command-events debugger-outer-unread-command-events)
       (setq unread-post-input-method-events
            debugger-outer-unread-post-input-method-events)
@@ -605,16 +595,7 @@
           (cursor-in-echo-area debugger-outer-cursor-in-echo-area))
       (set-match-data debugger-outer-match-data)
       (prog1
-         (let ((save-ucc (with-no-warnings unread-command-char)))
-           (unwind-protect
-               (progn
-                 (with-no-warnings
-                   (setq unread-command-char 
debugger-outer-unread-command-char))
-                 (prog1 (progn ,@body)
-                   (with-no-warnings
-                     (setq debugger-outer-unread-command-char 
unread-command-char))))
-             (with-no-warnings
-               (setq unread-command-char save-ucc))))
+          (progn ,@body)
         (setq debugger-outer-match-data (match-data))
         (setq debugger-outer-load-read-function load-read-function)
         (setq debugger-outer-overriding-terminal-local-map

=== modified file 'lisp/emacs-lisp/edebug.el'
--- a/lisp/emacs-lisp/edebug.el 2012-09-12 13:12:48 +0000
+++ b/lisp/emacs-lisp/edebug.el 2012-09-12 19:16:36 +0000
@@ -235,11 +235,6 @@
 
 ;;; Form spec utilities.
 
-(defmacro def-edebug-form-spec (symbol spec-form)
-  "For compatibility with old version."
-  (def-edebug-spec symbol (eval spec-form)))
-(make-obsolete 'def-edebug-form-spec 'def-edebug-spec "22.1")
-
 (defun get-edebug-spec (symbol)
   ;; Get the spec of symbol resolving all indirection.
   (let ((edebug-form-spec nil)

=== modified file 'lisp/progmodes/ebrowse.el'
--- a/lisp/progmodes/ebrowse.el 2012-07-11 23:13:41 +0000
+++ b/lisp/progmodes/ebrowse.el 2012-09-12 19:16:36 +0000
@@ -4210,7 +4210,7 @@
 ;; this will select the buffer from which the buffer menu was
 ;; invoked.  But this buffer is not displayed in the buffer list if
 ;; it isn't a tree buffer.  I therefore let the buffer menu command
-;; loop read the command `p' via `unread-command-char'.  This command
+;; loop read the command `p' via `unread-command-events'.  This command
 ;; has no effect since we are on the first line of the buffer.
 
 (defvar electric-buffer-menu-mode-hook nil)

=== modified file 'lisp/subr.el'
--- a/lisp/subr.el      2012-09-11 16:45:31 +0000
+++ b/lisp/subr.el      2012-09-12 19:16:36 +0000
@@ -1250,11 +1250,6 @@
  'mode-line-inverse-video
  "use the appropriate faces instead."
  "21.1")
-(make-obsolete-variable
- 'unread-command-char
- "use `unread-command-events' instead.  That variable is a list of events
-to reread, so it now uses nil to mean `no event', instead of -1."
- "before 19.15")
 
 ;; Lisp manual only updated in 22.1.
 (define-obsolete-variable-alias 'executing-macro 'executing-kbd-macro
@@ -3928,6 +3923,7 @@
                                   (lookup-key ',map
                                               (this-command-keys-vector))))
                             (t `(funcall ',keep-pred)))
+               (set ',overlaysym nil)   ;Just in case.
                (remove-hook 'pre-command-hook ',clearfunsym)
                (setq emulation-mode-map-alists
                      (delq ',alist emulation-mode-map-alists))))))

=== modified file 'src/ChangeLog'
--- a/src/ChangeLog     2012-09-12 19:14:02 +0000
+++ b/src/ChangeLog     2012-09-12 19:16:36 +0000
@@ -1,3 +1,9 @@
+2012-09-12  Stefan Monnier  <address@hidden>
+
+       * keyboard.c (read_char, requeued_events_pending_p, Finput_pending_p)
+       (Fdiscard_input, quit_throw_to_read_char, init_keyboard)
+       (syms_of_keyboard): Remove support for unread-command-char.
+
 2012-09-12  Eli Zaretskii  <address@hidden>
 
        * w32proc.c (sys_kill): If PID is our process ID and the signal is

=== modified file 'src/data.c'
--- a/src/data.c        2012-09-11 15:42:50 +0000
+++ b/src/data.c        2012-09-12 19:16:36 +0000
@@ -1164,7 +1164,7 @@
           the default binding is loaded, the loaded binding may be the
           wrong one.  */
        if (!EQ (blv->where, where)
-           /* Also unload a global binding (if the var is local_if_set). */
+           /* Also unload a global binding (if the var is local_if_set).  */
            || (EQ (blv->valcell, blv->defcell)))
          {
            /* The currently loaded binding is not necessarily valid.

=== modified file 'src/keyboard.c'
--- a/src/keyboard.c    2012-09-12 00:14:50 +0000
+++ b/src/keyboard.c    2012-09-12 19:16:36 +0000
@@ -2366,15 +2366,6 @@
       goto reread_first;
     }
 
-  if (unread_command_char != -1)
-    {
-      XSETINT (c, unread_command_char);
-      unread_command_char = -1;
-
-      reread = 1;
-      goto reread_first;
-    }
-
   if (CONSP (Vunread_command_events))
     {
       int was_disabled = 0;
@@ -2559,7 +2550,6 @@
       && !NILP (prev_event) && ! EVENT_HAS_PARAMETERS (prev_event)
       /* Don't bring up a menu if we already have another event.  */
       && NILP (Vunread_command_events)
-      && unread_command_char < 0
       && !detect_input_pending_run_timers (0))
     {
       c = read_char_minibuf_menu_prompt (commandflag, nmaps, maps);
@@ -2695,8 +2685,7 @@
       && !EQ (XCAR (prev_event), Qmenu_bar)
       && !EQ (XCAR (prev_event), Qtool_bar)
       /* Don't bring up a menu if we already have another event.  */
-      && NILP (Vunread_command_events)
-      && unread_command_char < 0)
+      && NILP (Vunread_command_events))
     {
       c = read_char_x_menu_prompt (nmaps, maps, prev_event, used_mouse_menu);
 
@@ -10453,7 +10442,7 @@
 int
 requeued_events_pending_p (void)
 {
-  return (!NILP (Vunread_command_events) || unread_command_char != -1);
+  return (!NILP (Vunread_command_events));
 }
 
 
@@ -10463,7 +10452,7 @@
 if there is a doubt, the value is t.  */)
   (void)
 {
-  if (!NILP (Vunread_command_events) || unread_command_char != -1
+  if (!NILP (Vunread_command_events)
       || !NILP (Vunread_post_input_method_events)
       || !NILP (Vunread_input_method_events))
     return (Qt);
@@ -10651,7 +10640,6 @@
   update_mode_lines++;
 
   Vunread_command_events = Qnil;
-  unread_command_char = -1;
 
   discard_tty_input ();
 
@@ -10991,7 +10979,6 @@
   input_pending = 0;
 
   Vunread_command_events = Qnil;
-  unread_command_char = -1;
 
 #if 0 /* Currently, sit_for is called from read_char without turning
         off polling.  And that can call set_waiting_for_input.
@@ -11378,12 +11365,11 @@
 void
 init_keyboard (void)
 {
-  /* This is correct before outermost invocation of the editor loop */
+  /* This is correct before outermost invocation of the editor loop.  */
   command_loop_level = -1;
   immediate_quit = 0;
   quit_char = Ctl ('g');
   Vunread_command_events = Qnil;
-  unread_command_char = -1;
   timer_idleness_start_time = invalid_emacs_time ();
   total_keys = 0;
   recent_keys_index = 0;
@@ -11716,9 +11702,6 @@
 An element of the form (t . EVENT) forces EVENT to be added to that list.  */);
   Vunread_command_events = Qnil;
 
-  DEFVAR_INT ("unread-command-char", unread_command_char,
-             doc: /* If not -1, an object to be read as next command input 
event.  */);
-
   DEFVAR_LISP ("unread-post-input-method-events", 
Vunread_post_input_method_events,
               doc: /* List of events to be processed as input by input methods.
 These events are processed before `unread-command-events'