[Emacs-diffs] /srv/bzr/emacs/emacs-24 r110913: More minor time fixes.

[Paul Eggert]

------------------------------------------------------------
revno: 110913
committer: Paul Eggert <address@hidden>
branch nick: emacs-24
timestamp: Sun 2012-11-18 09:10:35 -0800
message:
  More minor time fixes.
  
  * calendar/time-date.el: Commentary fix.
  * net/tramp-sh.el (tramp-do-file-attributes-with-ls): Undo last change;
  too much other code depends on (0 0) time stamps.
  * net/tramp.el (tramp-time-less-p, tramp-time-subtract):
  Add a couple of FIXME comments.
modified:
  lisp/ChangeLog
  lisp/calendar/time-date.el
  lisp/net/tramp-sh.el
  lisp/net/tramp.el

=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog    2012-11-18 02:13:19 +0000
+++ b/lisp/ChangeLog    2012-11-18 17:10:35 +0000
@@ -1,5 +1,12 @@
 2012-11-18  Paul Eggert  <address@hidden>
 
+       More minor time fixes.
+       * calendar/time-date.el: Commentary fix.
+       * net/tramp-sh.el (tramp-do-file-attributes-with-ls): Undo last change;
+       too much other code depends on (0 0) time stamps.
+       * net/tramp.el (tramp-time-less-p, tramp-time-subtract):
+       Add a couple of FIXME comments.
+
        Minor cleanup for times as lists of four integers.
        * files.el (dir-locals-directory-cache):
        * ps-bdf.el (bdf-file-mod-time, bdf-read-font-info):

=== modified file 'lisp/calendar/time-date.el'
--- a/lisp/calendar/time-date.el        2012-06-22 21:17:42 +0000
+++ b/lisp/calendar/time-date.el        2012-11-18 17:10:35 +0000
@@ -30,11 +30,10 @@
 ;; value equal to HIGH * 2^16 + LOW + USEC * 10^-6 + PSEC * 10^-12
 ;; seconds, where missing components are treated as zero.  HIGH can be
 ;; negative, either because the value is a time difference, or because
-;; the machine supports negative time stamps that fall before the
-;; epoch.  The macro `with-decoded-time-value' and the
-;; function `encode-time-value' make it easier to deal with these
-;; three formats.  See `time-subtract' for an example of how to use
-;; them.
+;; the machine supports negative time stamps that fall before the epoch.
+;; The macro `with-decoded-time-value' and the function
+;; `encode-time-value' make it easier to deal with these formats.
+;; See `time-subtract' for an example of how to use them.
 
 ;;; Code:
 

=== modified file 'lisp/net/tramp-sh.el'
--- a/lisp/net/tramp-sh.el      2012-11-18 02:13:19 +0000
+++ b/lisp/net/tramp-sh.el      2012-11-18 17:10:35 +0000
@@ -1270,11 +1270,12 @@
          res-uid
          ;; 3. File gid.
          res-gid
-         ;; 4. Last access time, as a list of integers in the same format
-         ;; as `current-time'.
+         ;; 4. Last access time, as a list of integers.  Normally this would be
+         ;; in the same format as `current-time', but the subseconds part is 
not
+         ;; currently implemented, and (0 0) denotes an unknown time.
          ;; 5. Last modification time, likewise.
          ;; 6. Last status change time, likewise.
-         '(0 0 0 0) '(0 0 0 0) '(0 0 0 0)      ;CCC how to find out?
+         '(0 0) '(0 0) '(0 0)          ;CCC how to find out?
          ;; 7. Size in bytes (-1, if number is out of range).
          res-size
          ;; 8. File modes, as a string of ten letters or dashes as in ls -l.

=== modified file 'lisp/net/tramp.el'
--- a/lisp/net/tramp.el 2012-10-09 12:49:02 +0000
+++ b/lisp/net/tramp.el 2012-11-18 17:10:35 +0000
@@ -3761,6 +3761,7 @@
     ("oct" . 10) ("nov" . 11) ("dec" . 12))
   "Alist mapping month names to integers.")
 
+;; FIXME: Shouldn't this also look at any subseconds parts of T1 and T2?
 ;;;###tramp-autoload
 (defun tramp-time-less-p (t1 t2)
   "Say whether time value T1 is less than time value T2."
@@ -3770,6 +3771,7 @@
       (and (= (car t1) (car t2))
           (< (nth 1 t1) (nth 1 t2)))))
 
+;; FIXME: Shouldn't this also look at any subseconds parts of T1 and T2?
 (defun tramp-time-subtract (t1 t2)
   "Subtract two time values.
 Return the difference in the format of a time value."