[Emacs-diffs] /srv/bzr/emacs/trunk r110957: Omit -Wstrict-overflow as it does not play well with --enable-checking.

[Paul Eggert]

------------------------------------------------------------
revno: 110957
committer: Paul Eggert <address@hidden>
branch nick: trunk
timestamp: Tue 2012-11-20 00:29:04 -0800
message:
  Omit -Wstrict-overflow as it does not play well with --enable-checking.
modified:
  ChangeLog
  configure.ac

=== modified file 'ChangeLog'
--- a/ChangeLog 2012-11-19 23:39:28 +0000
+++ b/ChangeLog 2012-11-20 08:29:04 +0000
@@ -1,8 +1,8 @@
-2012-11-19  Paul Eggert  <address@hidden>
+2012-11-20  Paul Eggert  <address@hidden>
 
        Improve static checking of integer overflow and stack smashing.
-       * configure.ac (WARN_CFLAGS): Add -Wstack-protector and
-       -Wstrict-overflow if using GCC 4.7.2 or later on a platform with
+       * configure.ac (WARN_CFLAGS): Add -Wstack-protector
+       if using GCC 4.7.2 or later on a platform with
        at least 64-bit long int.  This improves static checking on these
        platforms, when configured with --enable-gcc-warnings.
 

=== modified file 'configure.ac'
--- a/configure.ac      2012-11-19 23:39:28 +0000
+++ b/configure.ac      2012-11-20 08:29:04 +0000
@@ -710,6 +710,8 @@
   nw="$nw -Wfloat-equal"            # warns about high-quality code
   nw="$nw -Winline"                 # OK to ignore 'inline'
   nw="$nw -Wjump-misses-init"       # We sometimes safely jump over init.
+  nw="$nw -Wstrict-overflow"        # OK to optimize assuming that
+                                    # signed overflow has undefined behavior
   nw="$nw -Wsync-nand"              # irrelevant here, and provokes ObjC 
warning
   nw="$nw -Wunsafe-loop-optimizations" # OK to suppress unsafe optimizations
 
@@ -720,7 +722,7 @@
   # The following line should be removable at some point.
   nw="$nw -Wsuggest-attribute=pure"
 
-  AC_MSG_CHECKING([whether to use -Wstack-protector -Wstrict-overflow])
+  AC_MSG_CHECKING([whether to use -Wstack-protector])
   AC_PREPROC_IFELSE(
     [AC_LANG_PROGRAM(
        [[#if (1 <= __LONG_MAX__ >> 31 >> 31 \
@@ -732,8 +734,7 @@
        ]])],
     [AC_MSG_RESULT(yes)],
     [AC_MSG_RESULT(no)
-     nw="$nw -Wstack-protector"
-     nw="$nw -Wstrict-overflow"])
+     nw="$nw -Wstack-protector"])
 
   gl_MANYWARN_ALL_GCC([ws])
   gl_MANYWARN_COMPLEMENT([ws], [$ws], [$nw])