[Emacs-diffs] /srv/bzr/emacs/trunk r112410: * lisp/desktop.el (desktop-auto-save-timeout): New option.

[Juri Linkov]

------------------------------------------------------------
revno: 112410
committer: Juri Linkov <address@hidden>
branch nick: trunk
timestamp: Sat 2013-04-27 23:55:00 +0300
message:
  * lisp/desktop.el (desktop-auto-save-timeout): New option.
  (desktop-file-checksum): New variable.
  (desktop-save): Add optional arg `auto-save' and don't auto-save
  if nothing changed.
  (desktop-auto-save-timer): New variable.
  (desktop-auto-save, desktop-auto-save-set-timer): New functions.
  (after-init-hook): Call `desktop-auto-save-set-timer'.
  Suggested by Reuben Thomas <address@hidden> in
  <http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00327.html>.
modified:
  etc/NEWS
  lisp/ChangeLog
  lisp/desktop.el

=== modified file 'etc/NEWS'
--- a/etc/NEWS  2013-04-25 17:39:44 +0000
+++ b/etc/NEWS  2013-04-27 20:55:00 +0000
@@ -169,6 +169,11 @@
 
 *** Support for ISO 8601 dates.
 
+** Desktop
+
+*** `desktop-auto-save-timeout' defines the number of seconds between
+auto-saves of the desktop.
+
 ** Dired
 
 *** New minor mode `dired-hide-details-mode' hides details.

=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog    2013-04-27 17:07:01 +0000
+++ b/lisp/ChangeLog    2013-04-27 20:55:00 +0000
@@ -1,3 +1,15 @@
+2013-04-27  Juri Linkov  <address@hidden>
+
+       * desktop.el (desktop-auto-save-timeout): New option.
+       (desktop-file-checksum): New variable.
+       (desktop-save): Add optional arg `auto-save' and don't auto-save
+       if nothing changed.
+       (desktop-auto-save-timer): New variable.
+       (desktop-auto-save, desktop-auto-save-set-timer): New functions.
+       (after-init-hook): Call `desktop-auto-save-set-timer'.
+       Suggested by Reuben Thomas <address@hidden> in
+       <http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00327.html>.
+
 2013-04-27  Leo Liu  <address@hidden>
 
        * progmodes/octave.el (octave-function-file-p)
@@ -160,7 +172,7 @@
        (opascal-parse-next-literal, opascal-debug-unparse-buffer):
        Adjust callers.
 
-2013-04-24  Reuben Thomas <address@hidden>
+2013-04-24  Reuben Thomas  <address@hidden>
 
        * textmodes/remember.el (remember-handler-functions): Add an
        option for a new handler `remember-store-in-files'.

=== modified file 'lisp/desktop.el'
--- a/lisp/desktop.el   2013-03-26 03:38:18 +0000
+++ b/lisp/desktop.el   2013-04-27 20:55:00 +0000
@@ -189,6 +189,19 @@
   :group 'desktop
   :version "22.1")
 
+(defcustom desktop-auto-save-timeout nil
+  "Number of seconds between auto-saves of the desktop.
+Zero or nil means disable timer-based auto-saving."
+  :type '(choice (const :tag "Off" nil)
+                 (integer :tag "Seconds"))
+  :set (lambda (symbol value)
+         (set-default symbol value)
+         (condition-case nil
+            (desktop-auto-save-set-timer)
+          (error nil)))
+  :group 'desktop
+  :version "24.4")
+
 (defcustom desktop-load-locked-desktop 'ask
   "Specifies whether the desktop should be loaded if locked.
 Possible values are:
@@ -539,6 +552,10 @@
 (defvar desktop-delay-hook nil
   "Hooks run after all buffers are loaded; intended for internal use.")
 
+(defvar desktop-file-checksum nil
+  "Checksum of the last auto-saved contents of the desktop file.
+Used to avoid writing contents unchanged between auto-saves.")
+
 ;; ----------------------------------------------------------------------------
 ;; Desktop file conflict detection
 (defvar desktop-file-modtime nil
@@ -842,11 +859,12 @@
 
 ;; ----------------------------------------------------------------------------
 ;;;###autoload
-(defun desktop-save (dirname &optional release)
+(defun desktop-save (dirname &optional release auto-save)
   "Save the desktop in a desktop file.
 Parameter DIRNAME specifies where to save the desktop file.
 Optional parameter RELEASE says whether we're done with this desktop.
-See also `desktop-base-file-name'."
+If AUTO-SAVE is non-nil, compare the saved contents to the one last saved,
+and don't save the buffer if they are the same."
   (interactive "DDirectory to save desktop file in: ")
   (setq desktop-dirname (file-name-as-directory (expand-file-name dirname)))
   (save-excursion
@@ -906,10 +924,17 @@
                (insert ")\n\n"))))
 
          (setq default-directory desktop-dirname)
-         (let ((coding-system-for-write 'emacs-mule))
-           (write-region (point-min) (point-max) (desktop-full-file-name) nil 
'nomessage))
-         ;; We remember when it was modified (which is presumably just now).
-         (setq desktop-file-modtime (nth 5 (file-attributes 
(desktop-full-file-name)))))))))
+         ;; If auto-saving, avoid writing if nothing has changed since the 
last write.
+         ;; Don't check 300 characters of the header that contains the 
timestamp.
+         (let ((checksum (and auto-save (md5 (current-buffer)
+                                             (+ (point-min) 300) (point-max)
+                                             'emacs-mule))))
+           (unless (and auto-save (equal checksum desktop-file-checksum))
+             (let ((coding-system-for-write 'emacs-mule))
+               (write-region (point-min) (point-max) (desktop-full-file-name) 
nil 'nomessage))
+             (setq desktop-file-checksum checksum)
+             ;; We remember when it was modified (which is presumably just 
now).
+             (setq desktop-file-modtime (nth 5 (file-attributes 
(desktop-full-file-name)))))))))))
 
 ;; ----------------------------------------------------------------------------
 ;;;###autoload
@@ -1063,6 +1088,37 @@
   (message "Desktop saved in %s" (abbreviate-file-name desktop-dirname)))
 
 ;; ----------------------------------------------------------------------------
+;; Auto-Saving.
+(defvar desktop-auto-save-timer nil)
+
+(defun desktop-auto-save ()
+  "Save the desktop periodically.
+Called by the timer created in `desktop-auto-save-set-timer'."
+  (when (and desktop-save-mode
+            (integerp desktop-auto-save-timeout)
+            (> desktop-auto-save-timeout 0)
+            ;; Avoid desktop saving during lazy loading.
+            (not desktop-lazy-timer)
+            ;; Save only to own desktop file.
+            (eq (emacs-pid) (desktop-owner))
+            desktop-dirname)
+    (desktop-save desktop-dirname nil t))
+  (desktop-auto-save-set-timer))
+
+(defun desktop-auto-save-set-timer ()
+  "Reset the auto-save timer.
+Cancel any previous timer.  When `desktop-auto-save-timeout' is a positive
+integer, start a new timer to call `desktop-auto-save' in that many seconds."
+  (when desktop-auto-save-timer
+    (cancel-timer desktop-auto-save-timer)
+    (setq desktop-auto-save-timer nil))
+  (when (and (integerp desktop-auto-save-timeout)
+            (> desktop-auto-save-timeout 0))
+    (setq desktop-auto-save-timer
+         (run-with-timer desktop-auto-save-timeout nil
+                         'desktop-auto-save))))
+
+;; ----------------------------------------------------------------------------
 ;;;###autoload
 (defun desktop-revert ()
   "Revert to the last loaded desktop."
@@ -1315,6 +1371,7 @@
         (setq desktop-save-mode nil)))
     (when desktop-save-mode
       (desktop-read)
+      (desktop-auto-save-set-timer)
       (setq inhibit-startup-screen t))))
 
 (provide 'desktop)