emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] trunk r114991: * keyboard.c (Fcommand_error_default_functi


From: Paul Eggert
Subject: [Emacs-diffs] trunk r114991: * keyboard.c (Fcommand_error_default_function): Fix pointer signedness
Date: Tue, 05 Nov 2013 22:42:01 +0000
User-agent: Bazaar (2.6b2)

------------------------------------------------------------
revno: 114991
revision-id: address@hidden
parent: address@hidden
committer: Paul Eggert <address@hidden>
branch nick: trunk
timestamp: Tue 2013-11-05 14:41:57 -0800
message:
  * keyboard.c (Fcommand_error_default_function): Fix pointer signedness
  
  glitch.  Eliminate 'sz' prefix; Hungarian notation is not helpful here.
modified:
  src/ChangeLog                  changelog-20091113204419-o5vbwnq5f7feedwu-1438
  src/keyboard.c                 keyboard.c-20091113204419-o5vbwnq5f7feedwu-449
=== modified file 'src/ChangeLog'
--- a/src/ChangeLog     2013-11-05 20:47:54 +0000
+++ b/src/ChangeLog     2013-11-05 22:41:57 +0000
@@ -1,3 +1,8 @@
+2013-11-05  Paul Eggert  <address@hidden>
+
+       * keyboard.c (Fcommand_error_default_function): Fix pointer signedness
+       glitch.  Eliminate 'sz' prefix; Hungarian notation is not helpful here.
+
 2013-11-05  Stefan Monnier  <address@hidden>
 
        * keyboard.c (Fcommand_error_default_function): Rename from

=== modified file 'src/keyboard.c'
--- a/src/keyboard.c    2013-11-05 20:47:54 +0000
+++ b/src/keyboard.c    2013-11-05 22:41:57 +0000
@@ -1088,10 +1088,8 @@
   (Lisp_Object data, Lisp_Object context, Lisp_Object signal)
 {
   struct frame *sf = SELECTED_FRAME ();
-  const char *sz_context;
 
   CHECK_STRING (context);
-  sz_context = XSTRING (context)->data;
 
   /* If the window system or terminal frame hasn't been initialized
      yet, or we're not interactive, write the message to stderr and exit.  */
@@ -1110,7 +1108,7 @@
           || noninteractive)
     {
       print_error_message (data, Qexternal_debugging_output,
-                          sz_context, signal);
+                          SSDATA (context), signal);
       Fterpri (Qexternal_debugging_output);
       Fkill_emacs (make_number (-1));
     }
@@ -1121,7 +1119,7 @@
       message_log_maybe_newline ();
       bitch_at_user ();
 
-      print_error_message (data, Qt, sz_context, signal);
+      print_error_message (data, Qt, SSDATA (context), signal);
     }
   return Qnil;
 }


reply via email to

[Prev in Thread] Current Thread [Next in Thread]