emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] trunk r115283: Fix reftex-tests on MS-Windows.


From: Eli Zaretskii
Subject: [Emacs-diffs] trunk r115283: Fix reftex-tests on MS-Windows.
Date: Fri, 29 Nov 2013 10:34:13 +0000
User-agent: Bazaar (2.6b2)

------------------------------------------------------------
revno: 115283
revision-id: address@hidden
parent: address@hidden
committer: Eli Zaretskii <address@hidden>
branch nick: trunk
timestamp: Fri 2013-11-29 12:33:31 +0200
message:
  Fix reftex-tests on MS-Windows.
  
   test/automated/reftex-tests.el (reftex-parse-from-file-test): Run
   temp-dir through file-truename, to make sure the temporary file
   names are comparable as strings.
modified:
  test/ChangeLog                 changelog-20091113204419-o5vbwnq5f7feedwu-8588
  test/automated/reftex-tests.el 
reftextests.el-20130612124554-85p8611s89zewixv-1
=== modified file 'test/ChangeLog'
--- a/test/ChangeLog    2013-11-29 09:35:58 +0000
+++ b/test/ChangeLog    2013-11-29 10:33:31 +0000
@@ -1,5 +1,9 @@
 2013-11-29  Eli Zaretskii  <address@hidden>
 
+       * automated/reftex-tests.el (reftex-parse-from-file-test): Run
+       temp-dir through file-truename, to make sure the temporary file
+       names are comparable as strings.
+
        * automated/decoder-tests.el (ert-test-decoder-prefer-utf-8):
        Force Unix EOLs by using 'utf-8-unix', since the default of
        'utf-8' is system-dependent, while the test expects to see Unix

=== modified file 'test/automated/reftex-tests.el'
--- a/test/automated/reftex-tests.el    2013-06-12 14:43:46 +0000
+++ b/test/automated/reftex-tests.el    2013-11-29 10:33:31 +0000
@@ -95,7 +95,14 @@
 
 (ert-deftest reftex-parse-from-file-test ()
   "Test `reftex-parse-from-file'."
-  (let* ((temp-dir (make-temp-file "reftex-parse" 'dir))
+  ;; Use file-truename to convert 8+3 aliases in $TEMP value on
+  ;; MS-Windows into their long file-name equivalents, which is
+  ;; necessary for the 'equal' and 'string=' comparisons below.  This
+  ;; also resolves any symlinks, which cannot be bad for the same
+  ;; reason.  (An alternatrive solution would be to use file-equal-p,
+  ;; but I'm too lazy to do that, as one of the tests compares a
+  ;; list.)
+  (let* ((temp-dir (file-truename (make-temp-file "reftex-parse" 'dir)))
          (tex-file (expand-file-name "test.tex" temp-dir))
          (bib-file (expand-file-name "ref.bib" temp-dir)))
     (with-temp-buffer


reply via email to

[Prev in Thread] Current Thread [Next in Thread]