[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Emacs-diffs] trunk r115346: Fix minor log-edit-show-files annoyances
From: |
Dmitry Gutov |
Subject: |
[Emacs-diffs] trunk r115346: Fix minor log-edit-show-files annoyances |
Date: |
Mon, 02 Dec 2013 03:03:47 +0000 |
User-agent: |
Bazaar (2.6b2) |
------------------------------------------------------------
revno: 115346
revision-id: address@hidden
parent: address@hidden
committer: Dmitry Gutov <address@hidden>
branch nick: trunk
timestamp: Mon 2013-12-02 05:03:40 +0200
message:
Fix minor log-edit-show-files annoyances
* lisp/vc/log-edit.el (log-edit-kill-buffer): Move the use of
`save-selected-window' to `log-edit-hide-buf'. This makes
`log-edit-show-files' idempotent.
(log-edit-show-files): Mark the new window as dedicated.
modified:
lisp/ChangeLog changelog-20091113204419-o5vbwnq5f7feedwu-1432
lisp/vc/log-edit.el logedit.el-20091113204419-o5vbwnq5f7feedwu-1776
=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog 2013-12-02 02:24:31 +0000
+++ b/lisp/ChangeLog 2013-12-02 03:03:40 +0000
@@ -1,5 +1,12 @@
2013-12-02 Dmitry Gutov <address@hidden>
+ * vc/log-edit.el (log-edit-kill-buffer): Move the use of
+ `save-selected-window' to `log-edit-hide-buf'. This makes
+ `log-edit-show-files' idempotent.
+ (log-edit-show-files): Mark the new window as dedicated.
+
+2013-12-02 Dmitry Gutov <address@hidden>
+
* vc/log-edit.el (log-edit-mode-map): Add binding for
`log-edit-kill-biffer'.
(log-edit-hide-buf): Add a FIXME comment.
=== modified file 'lisp/vc/log-edit.el'
--- a/lisp/vc/log-edit.el 2013-12-02 02:26:07 +0000
+++ b/lisp/vc/log-edit.el 2013-12-02 03:03:40 +0000
@@ -483,9 +483,10 @@
;; FIXME: Should use something like `quit-windows-on' here, but
;; that function never deletes this buffer's window because it
;; was created using `cvs-pop-to-buffer-same-frame'.
- (let ((win (get-buffer-window buf where)))
- (if win (ignore-errors (delete-window win))))
- (bury-buffer buf)))
+ (save-selected-window
+ (let ((win (get-buffer-window buf where)))
+ (if win (ignore-errors (delete-window win))))
+ (bury-buffer buf))))
(defun log-edit-add-new-comment (comment)
(when (or (ring-empty-p log-edit-comment-ring)
@@ -545,8 +546,7 @@
`log-edit-files-buf'."
(interactive)
(log-edit-add-new-comment (buffer-string))
- (save-selected-window
- (log-edit-hide-buf))
+ (log-edit-hide-buf)
(let ((buf (current-buffer)))
(quit-windows-on buf)
(kill-buffer buf)))
@@ -604,6 +604,7 @@
(save-selected-window
(cvs-pop-to-buffer-same-frame buf)
(shrink-window-if-larger-than-buffer)
+ (set-window-dedicated-p (selected-window) t)
(selected-window)))))
(defun log-edit-beginning-of-line (&optional n)
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Emacs-diffs] trunk r115346: Fix minor log-edit-show-files annoyances,
Dmitry Gutov <=