[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Emacs-diffs] trunk r116935: Clean up array size calculations
|
From: |
Daniel Colascione |
|
Subject: |
[Emacs-diffs] trunk r116935: Clean up array size calculations |
|
Date: |
Thu, 03 Apr 2014 07:14:32 +0000 |
|
User-agent: |
Bazaar (2.6b2) |
------------------------------------------------------------
revno: 116935
revision-id: address@hidden
parent: address@hidden
committer: Daniel Colascione <address@hidden>
branch nick: trunk
timestamp: Thu 2014-04-03 00:14:02 -0700
message:
Clean up array size calculations
modified:
src/ChangeLog changelog-20091113204419-o5vbwnq5f7feedwu-1438
src/chartab.c chartab.c-20091113204419-o5vbwnq5f7feedwu-8539
src/dired.c dired.c-20091113204419-o5vbwnq5f7feedwu-171
src/dosfns.c dosfns.c-20091113204419-o5vbwnq5f7feedwu-653
src/emacs.c emacs.c-20091113204419-o5vbwnq5f7feedwu-241
src/fileio.c fileio.c-20091113204419-o5vbwnq5f7feedwu-210
src/frame.c frame.c-20091113204419-o5vbwnq5f7feedwu-243
src/fringe.c fringe.c-20091113204419-o5vbwnq5f7feedwu-2965
src/image.c image.c-20091113204419-o5vbwnq5f7feedwu-2969
src/keyboard.c keyboard.c-20091113204419-o5vbwnq5f7feedwu-449
src/macfont.m macfont.m-20130915173740-04lgloz0557bz98l-2
src/msdos.c msdos.c-20091113204419-o5vbwnq5f7feedwu-656
src/nsfns.m nsfns.m-20091113204419-o5vbwnq5f7feedwu-8741
src/nsterm.m nsterm.m-20091113204419-o5vbwnq5f7feedwu-8747
src/sysdep.c sysdep.c-20091113204419-o5vbwnq5f7feedwu-448
src/term.c term.c-20091113204419-o5vbwnq5f7feedwu-220
src/unexcw.c unexcw.c-20091113204419-o5vbwnq5f7feedwu-3010
src/w32.c w32.c-20091113204419-o5vbwnq5f7feedwu-808
src/w32fns.c w32fns.c-20091113204419-o5vbwnq5f7feedwu-945
src/xfaces.c xfaces.c-20091113204419-o5vbwnq5f7feedwu-560
src/xfns.c xfns.c-20091113204419-o5vbwnq5f7feedwu-274
src/xterm.c xterm.c-20091113204419-o5vbwnq5f7feedwu-244
=== modified file 'src/ChangeLog'
--- a/src/ChangeLog 2014-04-03 00:44:00 +0000
+++ b/src/ChangeLog 2014-04-03 07:14:02 +0000
@@ -1,5 +1,66 @@
2014-04-03 Daniel Colascione <address@hidden>
+ In all places below, change expressions of the form sizeof(arr) /
+ sizeof(arr[0]) to EARRAYSIZE(arr).
+
+ * xterm.c (x_term_init): See above.
+
+ * xfns.c (best_xim_style): See above.
+
+ * xfaces.c (Fdump_colors): See above.
+
+ * w32fns.c (w32_default_color_map): See above.
+
+ * w32.c:
+ (init_environment): See above.
+ (N_ENV_VARS): See above.
+
+ * unexcw.c (read_exe_header): See above.
+
+ * term.c (term_get_fkeys_1): See above.
+
+ * sysdep.c (init_baud_rate): See above.
+
+ * nsterm.m (ns_convert_key): See above.
+
+ * nsfns.m (get_geometry_from_preferences): See above.
+
+ * msdos.c (dos_set_window_size): See above.
+ (init_environment): See above.
+
+ * macfont.m (mac_font_get_glyph_for_cid): See above.
+ (macfont_store_descriptor_attributes): See above.
+ (macfont_create_attributes_with_spec): See above.
+ (mac_ctfont_get_glyph_for_cid): See above.
+
+ * keyboard.c (command_loop_1): See above.
+ (read_menu_command): See above.
+ (make_lispy_event): See above.
+ (NUM_MOD_NAMES): See above.
+ (read_key_sequence_vs): See above.
+ (Fcurrent_input_mode): See above.
+ (syms_of_keyboard): See above.
+
+ * image.c (xpm_str_to_color_key): See above.
+
+ * fringe.c (MAX_STANDARD_FRINGE_BITMAPS): See above.
+
+ * frame.c (x_set_frame_parameters): See above.
+
+ * fileio.c (Ffile_selinux_context): See above.
+
+ * emacs.c (sort_args): See above.
+
+ * dosfns.c ():
+ (msdos_stdcolor_name): See above.
+
+ * dired.c (file_attributes): See above.
+
+ * chartab.c:
+ (uniprop_decoder_count,uniprop_encode_count): See above.
+
+2014-04-02 Daniel Colascione <address@hidden>
+
* data.c (Ffset): Abort if we're trying to set a function call to
a dead lisp object.
=== modified file 'src/chartab.c'
--- a/src/chartab.c 2013-12-01 22:33:13 +0000
+++ b/src/chartab.c 2014-04-03 07:14:02 +0000
@@ -1221,9 +1221,7 @@
static uniprop_decoder_t uniprop_decoder [] =
{ uniprop_decode_value_run_length };
-static int uniprop_decoder_count
- = (sizeof uniprop_decoder) / sizeof (uniprop_decoder[0]);
-
+static const int uniprop_decoder_count = EARRAYSIZE (uniprop_decoder);
/* Return the decoder of char-table TABLE or nil if none. */
@@ -1301,9 +1299,7 @@
uniprop_encode_value_run_length,
uniprop_encode_value_numeric };
-static int uniprop_encoder_count
- = (sizeof uniprop_encoder) / sizeof (uniprop_encoder[0]);
-
+static const int uniprop_encoder_count = EARRAYSIZE (uniprop_encoder);
/* Return the encoder of char-table TABLE or nil if none. */
=== modified file 'src/dired.c'
--- a/src/dired.c 2014-01-01 07:43:34 +0000
+++ b/src/dired.c 2014-04-03 07:14:02 +0000
@@ -984,7 +984,7 @@
values[10] = INTEGER_TO_CONS (s.st_ino);
values[11] = INTEGER_TO_CONS (s.st_dev);
- return Flist (sizeof (values) / sizeof (values[0]), values);
+ return Flist (EARRAYSIZE (values), values);
}
DEFUN ("file-attributes-lessp", Ffile_attributes_lessp,
Sfile_attributes_lessp, 2, 2, 0,
=== modified file 'src/dosfns.c'
--- a/src/dosfns.c 2014-01-01 07:43:34 +0000
+++ b/src/dosfns.c 2014-04-03 07:14:02 +0000
@@ -402,7 +402,7 @@
{
int i;
- for (i = 0; i < sizeof (vga_colors) / sizeof (vga_colors[0]); i++)
+ for (i = 0; i < EARRAYSIZE (vga_colors); i++)
if (xstrcasecmp (name, vga_colors[i]) == 0)
return i;
@@ -422,7 +422,7 @@
return build_string (unspecified_fg);
else if (idx == FACE_TTY_DEFAULT_BG_COLOR)
return build_string (unspecified_bg);
- else if (idx >= 0 && idx < sizeof (vga_colors) / sizeof (vga_colors[0]))
+ else if (idx >= 0 && idx < EARRAYSIZE (vga_colors))
return build_string (vga_colors[idx]);
else
return Qunspecified; /* meaning the default */
=== modified file 'src/emacs.c'
--- a/src/emacs.c 2014-03-28 23:11:39 +0000
+++ b/src/emacs.c 2014-04-03 07:14:02 +0000
@@ -1817,7 +1817,7 @@
}
/* Look for a match with a known old-fashioned option. */
- for (i = 0; i < sizeof (standard_args) / sizeof (standard_args[0]);
i++)
+ for (i = 0; i < EARRAYSIZE (standard_args); i++)
if (!strcmp (argv[from], standard_args[i].name))
{
options[from] = standard_args[i].nargs;
@@ -1839,8 +1839,7 @@
match = -1;
- for (i = 0;
- i < sizeof (standard_args) / sizeof (standard_args[0]); i++)
+ for (i = 0; i < EARRAYSIZE (standard_args); i++)
if (standard_args[i].longname
&& !strncmp (argv[from], standard_args[i].longname,
thislen))
=== modified file 'src/fileio.c'
--- a/src/fileio.c 2014-03-26 15:57:13 +0000
+++ b/src/fileio.c 2014-04-03 07:14:02 +0000
@@ -2909,7 +2909,7 @@
}
#endif
- return Flist (sizeof (values) / sizeof (values[0]), values);
+ return Flist (EARRAYSIZE (values), values);
}
DEFUN ("set-file-selinux-context", Fset_file_selinux_context,
=== modified file 'src/frame.c'
--- a/src/frame.c 2014-03-30 13:31:45 +0000
+++ b/src/frame.c 2014-04-03 07:14:02 +0000
@@ -2867,8 +2867,7 @@
param_index = Fget (prop, Qx_frame_parameter);
if (NATNUMP (param_index)
- && (XFASTINT (param_index)
- < sizeof (frame_parms)/sizeof (frame_parms[0]))
+ && XFASTINT (param_index) < EARRAYSIZE (frame_parms)
&& FRAME_RIF (f)->frame_parm_handlers[XINT (param_index)])
(*(FRAME_RIF (f)->frame_parm_handlers[XINT (param_index)]))
(f, val, old_value);
}
@@ -2916,8 +2915,7 @@
param_index = Fget (prop, Qx_frame_parameter);
if (NATNUMP (param_index)
- && (XFASTINT (param_index)
- < sizeof (frame_parms)/sizeof (frame_parms[0]))
+ && XFASTINT (param_index) < EARRAYSIZE (frame_parms)
&& FRAME_RIF (f)->frame_parm_handlers[XINT (param_index)])
(*(FRAME_RIF (f)->frame_parm_handlers[XINT (param_index)])) (f,
val, old_value);
}
@@ -3228,8 +3226,7 @@
{
Lisp_Object parm_index = Fget (Qbackground_color, Qx_frame_parameter);
if (NATNUMP (parm_index)
- && (XFASTINT (parm_index)
- < sizeof (frame_parms)/sizeof (frame_parms[0]))
+ && XFASTINT (parm_index) < EARRAYSIZE (frame_parms)
&& FRAME_RIF (f)->frame_parm_handlers[XFASTINT (parm_index)])
(*FRAME_RIF (f)->frame_parm_handlers[XFASTINT (parm_index)])
(f, bgcolor, Qnil);
@@ -4563,7 +4560,7 @@
{
int i;
- for (i = 0; i < sizeof (frame_parms) / sizeof (frame_parms[0]); i++)
+ for (i = 0; i < EARRAYSIZE (frame_parms); i++)
{
Lisp_Object v = intern_c_string (frame_parms[i].name);
if (frame_parms[i].variable)
=== modified file 'src/fringe.c'
--- a/src/fringe.c 2014-02-05 10:46:44 +0000
+++ b/src/fringe.c 2014-04-03 07:14:02 +0000
@@ -474,7 +474,7 @@
#define NO_FRINGE_BITMAP 0
#define UNDEF_FRINGE_BITMAP 1
-#define MAX_STANDARD_FRINGE_BITMAPS (sizeof (standard_bitmaps)/sizeof
(standard_bitmaps[0]))
+#define MAX_STANDARD_FRINGE_BITMAPS EARRAYSIZE (standard_bitmaps)
static struct fringe_bitmap **fringe_bitmaps;
static Lisp_Object *fringe_faces;
=== modified file 'src/image.c'
--- a/src/image.c 2014-03-27 01:17:54 +0000
+++ b/src/image.c 2014-04-03 07:14:02 +0000
@@ -3955,9 +3955,7 @@
{
int i;
- for (i = 0;
- i < sizeof xpm_color_key_strings / sizeof xpm_color_key_strings[0];
- i++)
+ for (i = 0; i < EARRAYSIZE (xpm_color_key_strings); i++)
if (strcmp (xpm_color_key_strings[i], s) == 0)
return i;
return -1;
=== modified file 'src/keyboard.c'
--- a/src/keyboard.c 2014-03-26 10:21:55 +0000
+++ b/src/keyboard.c 2014-04-03 07:14:02 +0000
@@ -1446,7 +1446,7 @@
Vthis_command_keys_shift_translated = Qnil;
/* Read next key sequence; i gets its length. */
- i = read_key_sequence (keybuf, sizeof keybuf / sizeof keybuf[0],
+ i = read_key_sequence (keybuf, EARRAYSIZE (keybuf),
Qnil, 0, 1, 1, 0);
/* A filter may have run while we were reading the input. */
@@ -1694,7 +1694,7 @@
menus. */
specbind (Qecho_keystrokes, make_number (0));
- i = read_key_sequence (keybuf, sizeof keybuf / sizeof keybuf[0],
+ i = read_key_sequence (keybuf, EARRAYSIZE (keybuf),
Qnil, 0, 1, 1, 1);
unbind_to (count, Qnil);
@@ -5484,8 +5484,7 @@
event->modifiers,
Qfunction_key, Qnil,
lispy_accent_keys, &accent_key_syms,
- (sizeof (lispy_accent_keys)
- / sizeof (lispy_accent_keys[0])));
+ EARRAYSIZE (lispy_accent_keys));
#if 0
#ifdef XK_kana_A
@@ -5494,8 +5493,7 @@
event->modifiers & ~shift_modifier,
Qfunction_key, Qnil,
lispy_kana_keys, &func_key_syms,
- (sizeof (lispy_kana_keys)
- / sizeof (lispy_kana_keys[0])));
+ EARRAYSIZE (lispy_kana_keys));
#endif /* XK_kana_A */
#endif /* 0 */
@@ -5506,8 +5504,7 @@
event->modifiers,
Qfunction_key, Qnil,
iso_lispy_function_keys, &func_key_syms,
- (sizeof (iso_lispy_function_keys)
- / sizeof (iso_lispy_function_keys[0])));
+ EARRAYSIZE (iso_lispy_function_keys));
#endif
/* Handle system-specific or unknown keysyms. */
@@ -5533,20 +5530,17 @@
event->modifiers,
Qfunction_key, Qnil,
lispy_function_keys, &func_key_syms,
- (sizeof (lispy_function_keys)
- / sizeof (lispy_function_keys[0])));
+ EARRAYSIZE (lispy_function_keys));
#ifdef HAVE_NTGUI
case MULTIMEDIA_KEY_EVENT:
- if (event->code < (sizeof (lispy_multimedia_keys)
- / sizeof (lispy_multimedia_keys[0]))
+ if (event->code < EARRAYSIZE (lispy_multimedia_keys)
&& event->code > 0 && lispy_multimedia_keys[event->code])
{
return modify_event_symbol (event->code, event->modifiers,
Qfunction_key, Qnil,
lispy_multimedia_keys, &func_key_syms,
- (sizeof (lispy_multimedia_keys)
- / sizeof (lispy_multimedia_keys[0])));
+ EARRAYSIZE (lispy_multimedia_keys));
}
return Qnil;
#endif
@@ -6268,7 +6262,7 @@
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, "alt", "super", "hyper", "shift", "control", "meta"
};
-#define NUM_MOD_NAMES (sizeof (modifier_names) / sizeof (modifier_names[0]))
+#define NUM_MOD_NAMES EARRAYSIZE (modifier_names)
static Lisp_Object modifier_symbols;
@@ -9758,7 +9752,7 @@
memset (keybuf, 0, sizeof keybuf);
GCPRO1 (keybuf[0]);
- gcpro1.nvars = (sizeof keybuf / sizeof (keybuf[0]));
+ gcpro1.nvars = EARRAYSIZE (keybuf);
if (NILP (continue_echo))
{
@@ -9772,7 +9766,7 @@
cancel_hourglass ();
#endif
- i = read_key_sequence (keybuf, (sizeof keybuf / sizeof (keybuf[0])),
+ i = read_key_sequence (keybuf, EARRAYSIZE (keybuf),
prompt, ! NILP (dont_downcase_last),
! NILP (can_return_switch_frame), 0, 0);
@@ -10675,7 +10669,7 @@
}
XSETFASTINT (val[3], quit_char);
- return Flist (sizeof (val) / sizeof (val[0]), val);
+ return Flist (EARRAYSIZE (val), val);
}
DEFUN ("posn-at-x-y", Fposn_at_x_y, Sposn_at_x_y, 2, 4, 0,
@@ -11043,7 +11037,7 @@
{
int i;
- int len = sizeof (head_table) / sizeof (head_table[0]);
+ int len = EARRAYSIZE (head_table);
for (i = 0; i < len; i++)
{
@@ -11059,14 +11053,13 @@
staticpro (&button_down_location);
mouse_syms = Fmake_vector (make_number (5), Qnil);
staticpro (&mouse_syms);
- wheel_syms = Fmake_vector (make_number (sizeof (lispy_wheel_names)
- / sizeof (lispy_wheel_names[0])),
+ wheel_syms = Fmake_vector (make_number (EARRAYSIZE (lispy_wheel_names)),
Qnil);
staticpro (&wheel_syms);
{
int i;
- int len = sizeof (modifier_names) / sizeof (modifier_names[0]);
+ int len = EARRAYSIZE (modifier_names);
modifier_symbols = Fmake_vector (make_number (len), Qnil);
for (i = 0; i < len; i++)
=== modified file 'src/macfont.m'
--- a/src/macfont.m 2014-01-13 10:32:48 +0000
+++ b/src/macfont.m 2014-04-03 07:14:02 +0000
@@ -237,8 +237,7 @@
unichar characters[] = {0xfffd};
NSString *string =
[NSString stringWithCharacters:characters
- length:(sizeof (characters)
- / sizeof (characters[0]))];
+ length:EARRAYSIZE (characters)];
NSGlyphInfo *glyphInfo =
[NSGlyphInfo glyphInfoWithCharacterIdentifier:cid
collection:collection
@@ -826,7 +825,7 @@
{{0, 100}, {1, 200}, {CGFLOAT_MAX, CGFLOAT_MAX}}}};
int i;
- for (i = 0; i < sizeof (numeric_traits) / sizeof (numeric_traits[0]);
i++)
+ for (i = 0; i < EARRAYSIZE (numeric_traits); i++)
{
num = CFDictionaryGetValue (dict, numeric_traits[i].trait);
if (num && CFNumberGetValue (num, kCFNumberCGFloatType, &floatval))
@@ -1908,7 +1907,7 @@
if (! traits)
goto err;
- for (i = 0; i < sizeof (numeric_traits) / sizeof (numeric_traits[0]); i++)
+ for (i = 0; i < EARRAYSIZE (numeric_traits); i++)
{
tmp = AREF (spec, numeric_traits[i].index);
if (INTEGERP (tmp))
@@ -3584,7 +3583,7 @@
{
attributes = CFDictionaryCreate (NULL, (const void **) keys,
(const void **) values,
- sizeof (keys) / sizeof (keys[0]),
+ EARRAYSIZE (keys),
&kCFTypeDictionaryKeyCallBacks,
&kCFTypeDictionaryValueCallBacks);
CFRelease (values[1]);
@@ -3795,8 +3794,8 @@
CTLineRef ctline = NULL;
string = CFStringCreateWithCharacters (NULL, characters,
- sizeof (characters)
- / sizeof (characters[0]));
+ EARRAYSIZE (characters));
+
if (string)
{
CTGlyphInfoRef glyph_info =
@@ -3811,7 +3810,7 @@
attributes = CFDictionaryCreate (NULL, (const void **) keys,
(const void **) values,
- sizeof (keys) / sizeof (keys[0]),
+ EARRAYSIZE (keys),
&kCFTypeDictionaryKeyCallBacks,
&kCFTypeDictionaryValueCallBacks);
CFRelease (glyph_info);
=== modified file 'src/msdos.c'
--- a/src/msdos.c 2014-01-01 07:43:34 +0000
+++ b/src/msdos.c 2014-04-03 07:14:02 +0000
@@ -564,7 +564,7 @@
};
int i = 0;
- while (i < sizeof (std_dimension) / sizeof (std_dimension[0]))
+ while (i < EARRAYSIZE (std_dimension))
{
if (std_dimension[i].need_vga <= have_vga
&& std_dimension[i].rows >= *rows)
@@ -3465,7 +3465,7 @@
static const char * const tempdirs[] = {
"$TMPDIR", "$TEMP", "$TMP", "c:/"
};
- const int imax = sizeof (tempdirs) / sizeof (tempdirs[0]);
+ const int imax = EARRAYSIZE (tempdirs);
/* Make sure they have a usable $TMPDIR. Many Emacs functions use
temporary files and assume "/tmp" if $TMPDIR is unset, which
=== modified file 'src/nsfns.m'
--- a/src/nsfns.m 2014-02-11 18:05:01 +0000
+++ b/src/nsfns.m 2014-04-03 07:14:02 +0000
@@ -1024,7 +1024,7 @@
};
int i;
- for (i = 0; i < sizeof (r)/sizeof (r[0]); ++i)
+ for (i = 0; i < EARRAYSIZE (r); ++i)
{
if (NILP (Fassq (r[i].tem, parms)))
{
=== modified file 'src/nsterm.m'
--- a/src/nsterm.m 2014-03-30 17:21:20 +0000
+++ b/src/nsterm.m 2014-04-03 07:14:02 +0000
@@ -2012,8 +2012,7 @@
Internal call used by NSView-keyDown.
--------------------------------------------------------------------------
*/
{
- const unsigned last_keysym = (sizeof (convert_ns_to_X_keysym)
- / sizeof (convert_ns_to_X_keysym[0]));
+ const unsigned last_keysym = EARRAYSIZE (convert_ns_to_X_keysym);
unsigned keysym;
/* An array would be faster, but less easy to read. */
for (keysym = 0; keysym < last_keysym; keysym += 2)
=== modified file 'src/sysdep.c'
--- a/src/sysdep.c 2014-03-26 10:21:55 +0000
+++ b/src/sysdep.c 2014-04-03 07:14:02 +0000
@@ -255,7 +255,7 @@
#endif /* not DOS_NT */
}
- baud_rate = (emacs_ospeed < sizeof baud_convert / sizeof baud_convert[0]
+ baud_rate = (emacs_ospeed < EARRAYSIZE (baud_convert)
? baud_convert[emacs_ospeed] : 9600);
if (baud_rate == 0)
baud_rate = 1200;
=== modified file 'src/term.c'
--- a/src/term.c 2014-03-25 14:43:26 +0000
+++ b/src/term.c 2014-04-03 07:14:02 +0000
@@ -1339,7 +1339,7 @@
if (!KEYMAPP (KVAR (kboard, Vinput_decode_map)))
kset_input_decode_map (kboard, Fmake_sparse_keymap (Qnil));
- for (i = 0; i < (sizeof (keys) / sizeof (keys[0])); i++)
+ for (i = 0; i < EARRAYSIZE (keys); i++)
{
char *sequence = tgetstr (keys[i].cap, address);
if (sequence)
=== modified file 'src/unexcw.c'
--- a/src/unexcw.c 2014-03-21 07:26:47 +0000
+++ b/src/unexcw.c 2014-04-03 07:14:02 +0000
@@ -81,8 +81,7 @@
#endif
assert (exe_header_buffer->file_header.f_nscns > 0);
assert (exe_header_buffer->file_header.f_nscns <=
- sizeof (exe_header_buffer->section_header) /
- sizeof (exe_header_buffer->section_header[0]));
+ EARRAYSIZE (exe_header_buffer->section_header));
assert (exe_header_buffer->file_header.f_opthdr > 0);
ret =
=== modified file 'src/w32.c'
--- a/src/w32.c 2014-03-26 10:21:55 +0000
+++ b/src/w32.c 2014-04-03 07:14:02 +0000
@@ -1707,7 +1707,7 @@
/* We maintain 1-sec samples for the last 16 minutes in a circular buffer. */
static struct load_sample samples[16*60];
static int first_idx = -1, last_idx = -1;
-static int max_idx = sizeof (samples) / sizeof (samples[0]);
+static int max_idx = EARRAYSIZE (samples);
static int
buf_next (int from)
@@ -2511,7 +2511,7 @@
int i;
- const int imax = sizeof (tempdirs) / sizeof (tempdirs[0]);
+ const int imax = EARRAYSIZE (tempdirs);
/* Implementation note: This function explicitly works with ANSI
file names, not with UTF-8 encoded file names. This is because
@@ -2584,7 +2584,7 @@
{"LANG", NULL},
};
-#define N_ENV_VARS sizeof (dflt_envvars)/sizeof (dflt_envvars[0])
+#define N_ENV_VARS EARRAYSIZE (dflt_envvars)
/* We need to copy dflt_envvars[] and work on the copy because we
don't want the dumped Emacs to inherit the values of
=== modified file 'src/w32fns.c'
--- a/src/w32fns.c 2014-03-26 10:21:55 +0000
+++ b/src/w32fns.c 2014-04-03 07:14:02 +0000
@@ -723,8 +723,7 @@
cmap = Qnil;
- for (i = 0; i < sizeof (w32_color_map) / sizeof (w32_color_map[0]);
- pc++, i++)
+ for (i = 0; i < EARRAYSIZE (w32_color_map); pc++, i++)
cmap = Fcons (Fcons (build_string (pc->name),
make_number (pc->colorref)),
cmap);
=== modified file 'src/xfaces.c'
--- a/src/xfaces.c 2014-02-04 07:36:58 +0000
+++ b/src/xfaces.c 2014-04-03 07:14:02 +0000
@@ -515,7 +515,7 @@
fputc ('\n', stderr);
- for (i = n = 0; i < sizeof color_count / sizeof color_count[0]; ++i)
+ for (i = n = 0; i < EARRAYSIZE (color_count); ++i)
if (color_count[i])
{
fprintf (stderr, "%3d: %5d", i, color_count[i]);
=== modified file 'src/xfns.c'
--- a/src/xfns.c 2014-03-23 11:44:21 +0000
+++ b/src/xfns.c 2014-04-03 07:14:02 +0000
@@ -1944,8 +1944,7 @@
best_xim_style (XIMStyles *xim)
{
int i, j;
- int nr_supported =
- sizeof (supported_xim_styles) / sizeof (supported_xim_styles[0]);
+ int nr_supported = EARRAYSIZE (supported_xim_styles);
for (i = 0; i < nr_supported; ++i)
for (j = 0; j < xim->count_styles; ++j)
=== modified file 'src/xterm.c'
--- a/src/xterm.c 2014-04-02 16:17:08 +0000
+++ b/src/xterm.c 2014-04-03 07:14:02 +0000
@@ -10103,7 +10103,7 @@
};
int i;
- const int atom_count = sizeof (atom_refs) / sizeof (atom_refs[0]);
+ const int atom_count = EARRAYSIZE (atom_refs);
/* 1 for _XSETTINGS_SN */
const int total_atom_count = 1 + atom_count;
Atom *atoms_return = xmalloc (total_atom_count * sizeof *atoms_return);
| [Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Emacs-diffs] trunk r116935: Clean up array size calculations,
Daniel Colascione <=