[Emacs-diffs] trunk r117000: Fix cl-loop destructuring under `with' clause

[Daniel Colascione]

------------------------------------------------------------
revno: 117000
revision-id: address@hidden
parent: address@hidden
committer: Daniel Colascione <address@hidden>
branch nick: trunk
timestamp: Sun 2014-04-20 18:03:39 -0700
message:
  Fix cl-loop destructuring under `with' clause
modified:
  lisp/ChangeLog                 changelog-20091113204419-o5vbwnq5f7feedwu-1432
  lisp/emacs-lisp/cl-macs.el     clmacs.el-20091113204419-o5vbwnq5f7feedwu-612
  test/ChangeLog                 changelog-20091113204419-o5vbwnq5f7feedwu-8588
  test/automated/cl-lib.el       cllib.el-20130711160611-o23w1tyz0y13jq8e-1

=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog    2014-04-20 23:24:04 +0000
+++ b/lisp/ChangeLog    2014-04-21 01:03:39 +0000
@@ -1,3 +1,8 @@
+2014-04-21  Daniel Colascione  <address@hidden>
+
+       * emacs-lisp/cl-macs.el:
+       (cl--loop-let): Properly destructure `while' clauses.
+
 2014-04-20  Daniel Colascione  <address@hidden>
 
        * vc/vc.el (vc-root-dir): New public autoloaded function for

=== modified file 'lisp/emacs-lisp/cl-macs.el'
--- a/lisp/emacs-lisp/cl-macs.el        2014-04-20 14:46:13 +0000
+++ b/lisp/emacs-lisp/cl-macs.el        2014-04-21 01:03:39 +0000
@@ -1550,7 +1550,7 @@
               (if (and (cl--unused-var-p temp) (null expr))
                   nil ;; Don't bother declaring/setting `temp' since it won't
                      ;; be used when `expr' is nil, anyway.
-                (when (and (eq body 'setq) (cl--unused-var-p temp))
+                (when (cl--unused-var-p temp)
                   ;; Prefer a fresh uninterned symbol over "_to", to avoid
                   ;; warnings that we set an unused variable.
                   (setq temp (make-symbol "--cl-var--"))

=== modified file 'test/ChangeLog'
--- a/test/ChangeLog    2014-04-20 02:34:22 +0000
+++ b/test/ChangeLog    2014-04-21 01:03:39 +0000
@@ -1,3 +1,7 @@
+2014-04-21  Daniel Colascione  <address@hidden>
+
+       * automated/cl-lib.el (cl-loop-destructuring-with): New test.
+
 2014-04-20  Daniel Colascione  <address@hidden>
 
        * automated/cl-lib.el (cl-lib-struct-accessors,cl-the): New tests.

=== modified file 'test/automated/cl-lib.el'
--- a/test/automated/cl-lib.el  2014-04-20 02:34:22 +0000
+++ b/test/automated/cl-lib.el  2014-04-21 01:03:39 +0000
@@ -220,4 +220,7 @@
     (should (= (the integer (incf sideffect)) 1))
     (should (= sideffect 1))))
 
+(ert-deftest cl-loop-destructuring-with ()
+  (should (equal (cl-loop with (a b c) = '(1 2 3) return (+ a b c)) 6)))
+
 ;;; cl-lib.el ends here