[Emacs-diffs] trunk r117367: Minor cleanup of fonset code.

[Dmitry Antipov]

------------------------------------------------------------
revno: 117367
revision-id: address@hidden
parent: address@hidden
committer: Dmitry Antipov <address@hidden>
branch nick: trunk
timestamp: Thu 2014-06-19 20:52:20 +0400
message:
  Minor cleanup of fonset code.
  * fontset.c (FONTSET_ID, set_fontset_id, FONTSET_NAME)
  (set_fontset_name, FONTSET_ASCII, set_fontset_ascii)
  (FONTSET_BASE, set_fontset_base, FONTSET_FRAME)
  (set_fontset_frame, FONTSET_NOFONT_FACE, set_fontset_nofont_face)
  (FONTSET_DEFAULT, set_fontset_default, FONTSET_FALLBACK)
  (set_fontset_fallback): Reorder extra slots and avoid unused slots.
  (free_realized_fontset): Remove because a no-op since 2008.
  (free_face_fontset): Adjust user.
  (syms_of_fontset): Shrink fontset by one extra slot.
modified:
  src/ChangeLog                  changelog-20091113204419-o5vbwnq5f7feedwu-1438
  src/fontset.c                  fontset.c-20091113204419-o5vbwnq5f7feedwu-1079

=== modified file 'src/ChangeLog'
--- a/src/ChangeLog     2014-06-17 16:09:19 +0000
+++ b/src/ChangeLog     2014-06-19 16:52:20 +0000
@@ -1,3 +1,16 @@
+2014-06-19  Dmitry Antipov  <address@hidden>
+
+       Minor cleanup of fonset code.
+       * fontset.c (FONTSET_ID, set_fontset_id, FONTSET_NAME)
+       (set_fontset_name, FONTSET_ASCII, set_fontset_ascii)
+       (FONTSET_BASE, set_fontset_base, FONTSET_FRAME)
+       (set_fontset_frame, FONTSET_NOFONT_FACE, set_fontset_nofont_face)
+       (FONTSET_DEFAULT, set_fontset_default, FONTSET_FALLBACK)
+       (set_fontset_fallback): Reorder extra slots and avoid unused slots.
+       (free_realized_fontset): Remove because a no-op since 2008.
+       (free_face_fontset): Adjust user.
+       (syms_of_fontset): Shrink fontset by one extra slot.
+
 2014-06-17  Paul Eggert  <address@hidden>
 
        Omit redundant extern decls.

=== modified file 'src/fontset.c'
--- a/src/fontset.c     2014-01-01 07:43:34 +0000
+++ b/src/fontset.c     2014-06-19 16:52:20 +0000
@@ -209,27 +209,27 @@
   set_char_table_extras (fontset, 1, name);
 }
 
-#define FONTSET_ASCII(fontset) XCHAR_TABLE (fontset)->extras[4]
+#define FONTSET_ASCII(fontset) XCHAR_TABLE (fontset)->extras[2]
 static void
 set_fontset_ascii (Lisp_Object fontset, Lisp_Object ascii)
 {
-  set_char_table_extras (fontset, 4, ascii);
+  set_char_table_extras (fontset, 2, ascii);
 }
 
 /* Access special values of (realized) FONTSET.  */
 
-#define FONTSET_BASE(fontset) XCHAR_TABLE (fontset)->extras[2]
+#define FONTSET_BASE(fontset) XCHAR_TABLE (fontset)->extras[3]
 static void
 set_fontset_base (Lisp_Object fontset, Lisp_Object base)
 {
-  set_char_table_extras (fontset, 2, base);
+  set_char_table_extras (fontset, 3, base);
 }
 
-#define FONTSET_FRAME(fontset) XCHAR_TABLE (fontset)->extras[3]
+#define FONTSET_FRAME(fontset) XCHAR_TABLE (fontset)->extras[4]
 static void
 set_fontset_frame (Lisp_Object fontset, Lisp_Object frame)
 {
-  set_char_table_extras (fontset, 3, frame);
+  set_char_table_extras (fontset, 4, frame);
 }
 
 #define FONTSET_NOFONT_FACE(fontset) XCHAR_TABLE (fontset)->extras[5]
@@ -239,20 +239,20 @@
   set_char_table_extras (fontset, 5, face);
 }
 
-#define FONTSET_DEFAULT(fontset) XCHAR_TABLE (fontset)->extras[7]
+#define FONTSET_DEFAULT(fontset) XCHAR_TABLE (fontset)->extras[6]
 static void
 set_fontset_default (Lisp_Object fontset, Lisp_Object def)
 {
-  set_char_table_extras (fontset, 7, def);
+  set_char_table_extras (fontset, 6, def);
 }
 
 /* For both base and realized fontset.  */
 
-#define FONTSET_FALLBACK(fontset) XCHAR_TABLE (fontset)->extras[8]
+#define FONTSET_FALLBACK(fontset) XCHAR_TABLE (fontset)->extras[7]
 static void
 set_fontset_fallback (Lisp_Object fontset, Lisp_Object fallback)
 {
-  set_char_table_extras (fontset, 8, fallback);
+  set_char_table_extras (fontset, 7, fallback);
 }
 
 #define BASE_FONTSET_P(fontset) (NILP (FONTSET_BASE (fontset)))
@@ -852,21 +852,6 @@
   return elt;
 }
 
-static void
-free_realized_fontset (struct frame *f, Lisp_Object fontset)
-{
-#if 0
-  Lisp_Object tail;
-
-  if (0)
-    for (tail = FONTSET_OBJLIST (fontset); CONSP (tail); tail = XCDR (tail))
-      {
-       eassert (FONT_OBJECT_P (XCAR (tail)));
-       font_close_object (f, XCAR (tail));
-      }
-#endif
-}
-
 /* Free fontset of FACE defined on frame F.  Called from
    free_realized_face.  */
 
@@ -880,7 +865,6 @@
     return;
   eassert (! BASE_FONTSET_P (fontset));
   eassert (f == XFRAME (FONTSET_FRAME (fontset)));
-  free_realized_fontset (f, fontset);
   ASET (Vfontset_table, face->fontset, Qnil);
   if (face->fontset < next_fontset_id)
     next_fontset_id = face->fontset;
@@ -891,7 +875,6 @@
       fontset = AREF (Vfontset_table, id);
       eassert (!NILP (fontset) && ! BASE_FONTSET_P (fontset));
       eassert (f == XFRAME (FONTSET_FRAME (fontset)));
-      free_realized_fontset (f, fontset);
       ASET (Vfontset_table, id, Qnil);
       if (id < next_fontset_id)
        next_fontset_id = face->fontset;
@@ -2159,7 +2142,7 @@
 syms_of_fontset (void)
 {
   DEFSYM (Qfontset, "fontset");
-  Fput (Qfontset, Qchar_table_extra_slots, make_number (9));
+  Fput (Qfontset, Qchar_table_extra_slots, make_number (8));
   DEFSYM (Qfontset_info, "fontset-info");
   Fput (Qfontset_info, Qchar_table_extra_slots, make_number (1));