emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] trunk r117400: Try to fix some flymake-tests weirdness


From: Glenn Morris
Subject: [Emacs-diffs] trunk r117400: Try to fix some flymake-tests weirdness
Date: Wed, 25 Jun 2014 19:12:18 +0000
User-agent: Bazaar (2.6b2)

------------------------------------------------------------
revno: 117400
revision-id: address@hidden
parent: address@hidden
committer: Glenn Morris <address@hidden>
branch nick: trunk
timestamp: Wed 2014-06-25 15:12:14 -0400
message:
  Try to fix some flymake-tests weirdness
  
  * test/automated/flymake-tests.el (flymake-tests--current-face):
  Sleep for longer.  Avoid querying.
modified:
  test/ChangeLog                 changelog-20091113204419-o5vbwnq5f7feedwu-8588
  test/automated/flymake-tests.el 
flymaketests.el-20130621142346-ara3p0outs2ckhw3-2
=== modified file 'test/ChangeLog'
--- a/test/ChangeLog    2014-06-25 10:36:51 +0000
+++ b/test/ChangeLog    2014-06-25 19:12:14 +0000
@@ -1,3 +1,8 @@
+2014-06-25  Glenn Morris  <address@hidden>
+
+       * automated/flymake-tests.el (flymake-tests--current-face):
+       Sleep for longer.  Avoid querying.
+
 2014-06-25  Dmitry Antipov  <address@hidden>
 
        * automated/fns-tests.el (fns-tests-compare-string): New test.

=== modified file 'test/automated/flymake-tests.el'
--- a/test/automated/flymake-tests.el   2014-01-01 07:43:34 +0000
+++ b/test/automated/flymake-tests.el   2014-06-25 19:12:14 +0000
@@ -40,10 +40,15 @@
           (goto-char (point-min))
           (flymake-mode 1)
           ;; XXX: is this reliable enough?
+          ;; By experiment, no it is not!
+          ;; For some reason, a single (sleep-for 1.0) does nothing here,
+          ;; but 2 * (sleep-for 0.5) works.
+          ;; FIXME what is going on...?
+          (sleep-for (+ 0.5 flymake-no-changes-timeout))
           (sleep-for (+ 0.5 flymake-no-changes-timeout))
           (flymake-goto-next-error)
           (face-at-point))
-      (and buffer (kill-buffer buffer)))))
+      (and buffer (let (kill-buffer-query-functions) (kill-buffer buffer))))))
 
 (ert-deftest warning-predicate-rx-gcc ()
   "Test GCC warning via regexp predicate."


reply via email to

[Prev in Thread] Current Thread [Next in Thread]