[Emacs-diffs] trunk r117401: * flymake-tests.el (flymake-tests--current-face): Tweak previous sleep change.

[Glenn Morris]

------------------------------------------------------------
revno: 117401
revision-id: address@hidden
parent: address@hidden
committer: Glenn Morris <address@hidden>
branch nick: trunk
timestamp: Wed 2014-06-25 18:59:37 -0400
message:
  * flymake-tests.el (flymake-tests--current-face): Tweak previous sleep change.
  Using the time-honored principle of "if it doesn't when you do X,
  do it again and see what happens".
modified:
  test/automated/flymake-tests.el 
flymaketests.el-20130621142346-ara3p0outs2ckhw3-2

=== modified file 'test/automated/flymake-tests.el'
--- a/test/automated/flymake-tests.el   2014-06-25 19:12:14 +0000
+++ b/test/automated/flymake-tests.el   2014-06-25 22:59:37 +0000
@@ -33,19 +33,16 @@
 ;; Warning predicate
 (defun flymake-tests--current-face (file predicate)
   (let ((buffer (find-file-noselect
-                 (expand-file-name file flymake-tests-data-directory))))
+                 (expand-file-name file flymake-tests-data-directory)))
+        (i 0))
     (unwind-protect
         (with-current-buffer buffer
           (setq-local flymake-warning-predicate predicate)
           (goto-char (point-min))
           (flymake-mode 1)
-          ;; XXX: is this reliable enough?
-          ;; By experiment, no it is not!
-          ;; For some reason, a single (sleep-for 1.0) does nothing here,
-          ;; but 2 * (sleep-for 0.5) works.
-          ;; FIXME what is going on...?
-          (sleep-for (+ 0.5 flymake-no-changes-timeout))
-          (sleep-for (+ 0.5 flymake-no-changes-timeout))
+          ;; Weirdness here...  http://debbugs.gnu.org/17647#25
+          (while (and flymake-is-running (< (setq i (1+ i)) 10))
+            (sleep-for (+ 0.5 flymake-no-changes-timeout)))
           (flymake-goto-next-error)
           (face-at-point))
       (and buffer (let (kill-buffer-query-functions) (kill-buffer buffer))))))