[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Emacs-diffs] emacs-24 r117530: * xfaces.c (Finternal_set_lisp_face_attr
From: |
Jan D. |
Subject: |
[Emacs-diffs] emacs-24 r117530: * xfaces.c (Finternal_set_lisp_face_attribute): Added FIXME comment. |
Date: |
Wed, 01 Oct 2014 18:10:32 +0000 |
User-agent: |
Bazaar (2.6b2) |
------------------------------------------------------------
revno: 117530
revision-id: address@hidden
parent: address@hidden
committer: Jan D. <address@hidden>
branch nick: emacs-24
timestamp: Wed 2014-10-01 20:10:21 +0200
message:
* xfaces.c (Finternal_set_lisp_face_attribute): Added FIXME comment.
modified:
src/ChangeLog changelog-20091113204419-o5vbwnq5f7feedwu-1438
src/xfaces.c xfaces.c-20091113204419-o5vbwnq5f7feedwu-560
=== modified file 'src/ChangeLog'
--- a/src/ChangeLog 2014-10-01 17:41:18 +0000
+++ b/src/ChangeLog 2014-10-01 18:10:21 +0000
@@ -2,6 +2,7 @@
* xfaces.c (Finternal_set_lisp_face_attribute): Don't try to
make a font_object from a tty frame (Bug#18573).
+ (Finternal_set_lisp_face_attribute): Added FIXME comment.
2014-09-30 Eli Zaretskii <address@hidden>
=== modified file 'src/xfaces.c'
--- a/src/xfaces.c 2014-10-01 17:41:18 +0000
+++ b/src/xfaces.c 2014-10-01 18:10:21 +0000
@@ -3119,6 +3119,13 @@
f = XFRAME (selected_frame);
else
f = XFRAME (frame);
+
+ /* FIXME:
+ If frame is t, and selected frame is a tty frame, the font
+ can't be realized. An improvement wuld be to loop over frames
+ for a non-tty frame and use that. See discussion in
+ bug#18573.
+ */
if (f->terminal->type != output_termcap)
{
if (! FONT_OBJECT_P (value))
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Emacs-diffs] emacs-24 r117530: * xfaces.c (Finternal_set_lisp_face_attribute): Added FIXME comment.,
Jan D. <=