[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Emacs-diffs] master 7e8f7e0: * test/automated/ert-tests.el (ert-test-de
From: |
Stefan Monnier |
Subject: |
[Emacs-diffs] master 7e8f7e0: * test/automated/ert-tests.el (ert-test-deftest): Add FIXME. |
Date: |
Sat, 08 Aug 2015 23:43:20 +0000 |
branch: master
commit 7e8f7e089f3e72644c9a6e0d022d51d3166bbb07
Author: Stefan Monnier <address@hidden>
Commit: Stefan Monnier <address@hidden>
* test/automated/ert-tests.el (ert-test-deftest): Add FIXME.
---
test/automated/ert-tests.el | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/test/automated/ert-tests.el b/test/automated/ert-tests.el
index fcfc7ee..5382c40 100644
--- a/test/automated/ert-tests.el
+++ b/test/automated/ert-tests.el
@@ -345,6 +345,10 @@ This macro is used to test if macroexpansion in `should'
works."
(should (equal actual-condition expected-condition)))))))
(ert-deftest ert-test-deftest ()
+ ;; FIXME: These tests don't look very good. What is their intent, i.e. what
+ ;; are they really testing? The precise generated code shouldn't matter, so
+ ;; we should either test the behavior of the code, or else try to express the
+ ;; kind of efficiency guarantees we're looking for.
(should (equal (macroexpand '(ert-deftest abc () "foo" :tags '(bar)))
'(progn
(ert-set-test 'abc
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Emacs-diffs] master 7e8f7e0: * test/automated/ert-tests.el (ert-test-deftest): Add FIXME.,
Stefan Monnier <=