emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] master 61dc103: ; * src/emacs-module.c (funcall_module): A


From: Philipp Stephani
Subject: [Emacs-diffs] master 61dc103: ; * src/emacs-module.c (funcall_module): Add another FIXME
Date: Sat, 17 Jun 2017 11:11:11 -0400 (EDT)

branch: master
commit 61dc103969fce1a0bf179e9e799d1feba128b525
Author: Philipp Stephani <address@hidden>
Commit: Philipp Stephani <address@hidden>

    ; * src/emacs-module.c (funcall_module): Add another FIXME
---
 src/emacs-module.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/emacs-module.c b/src/emacs-module.c
index 5c413ee..2693a45 100644
--- a/src/emacs-module.c
+++ b/src/emacs-module.c
@@ -768,6 +768,9 @@ funcall_module (Lisp_Object function, ptrdiff_t nargs, 
Lisp_Object *arglist)
   USE_SAFE_ALLOCA;
   ATTRIBUTE_MAY_ALIAS emacs_value *args;
   if (plain_values && ! module_assertions)
+    /* FIXME: The cast below is incorrect because the argument array
+       is not declared as const, so module functions can modify it.
+       Either declare it as const, or remove this branch.  */
     args = (emacs_value *) arglist;
   else
     {



reply via email to

[Prev in Thread] Current Thread [Next in Thread]