emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] master 37954f3 1/2: Revert "Let delete-selection-mode work


From: Noam Postavsky
Subject: [Emacs-diffs] master 37954f3 1/2: Revert "Let delete-selection-mode work with popup-menu commands (Bug#27569)"
Date: Sat, 22 Jul 2017 10:32:59 -0400 (EDT)

branch: master
commit 37954f39168e0dbfe3a82feb9b58fecfc5f1f318
Author: Noam Postavsky <address@hidden>
Commit: Noam Postavsky <address@hidden>

    Revert "Let delete-selection-mode work with popup-menu commands (Bug#27569)"
    
    It turns out that this change is not needed, and it leaves several
    command loops settings not done.
    
    https://lists.gnu.org/archive/html/emacs-devel/2017-07/msg00757.html
    https://lists.gnu.org/archive/html/emacs-devel/2017-07/msg00840.html
---
 lisp/menu-bar.el | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/lisp/menu-bar.el b/lisp/menu-bar.el
index 4a56978..3ca7d1b 100644
--- a/lisp/menu-bar.el
+++ b/lisp/menu-bar.el
@@ -2375,10 +2375,6 @@ FROM-MENU-BAR, if non-nil, means we are dropping one of 
menu-bar's menus."
       ;; `setup-specified-language-environment', for instance,
       ;; expects this to be set from a menu keymap.
       (setq last-command-event (car (last event)))
-      ;; Update `this-command' and run `pre-command-hook' so that
-      ;; things like `delete-selection-pre-hook' will work correctly.
-      (setq this-command cmd)
-      (run-hooks 'pre-command-hook)
       ;; mouse-major-mode-menu was using `command-execute' instead.
       (call-interactively cmd))))
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]