emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] master c8f44e4: ls-lisp: Do not require em-glob at top of


From: Tino Calancha
Subject: [Emacs-diffs] master c8f44e4: ls-lisp: Do not require em-glob at top of the file
Date: Sun, 30 Jul 2017 07:29:06 -0400 (EDT)

branch: master
commit c8f44e4b53c40dfea1c83ad0ff3bd653e72c4f4e
Author: Tino Calancha <address@hidden>
Commit: Tino Calancha <address@hidden>

    ls-lisp: Do not require em-glob at top of the file
    
    Require em-glob inside 'ls-lisp--dired'.  This is necessary to
    not break the Emacs build.
    See following thread for details:
    https://lists.gnu.org/archive/html/emacs-devel/2017-07/msg01083.html
    * lisp/ls-lisp.el (dired-goto-next-file)
    (dired-read-dir-and-switches, eshell-extended-glob):
    Add function declarations.
    * lisp/eshell/em-ls.el (dired-goto-next-file): Fix function declaration.
---
 lisp/eshell/em-ls.el | 2 +-
 lisp/ls-lisp.el      | 6 +++++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/lisp/eshell/em-ls.el b/lisp/eshell/em-ls.el
index 948ac38..4a5adc4 100644
--- a/lisp/eshell/em-ls.el
+++ b/lisp/eshell/em-ls.el
@@ -283,7 +283,7 @@ instead."
 
 (declare-function eshell-extended-glob "em-glob" (glob))
 (declare-function dired-read-dir-and-switches "dired" (str))
-(declare-function dired-goto-next-file "em-glob" ())
+(declare-function dired-goto-next-file "dired" ())
 
 (defun eshell-ls--dired (orig-fun dir-or-list &optional switches)
   (interactive (dired-read-dir-and-switches ""))
diff --git a/lisp/ls-lisp.el b/lisp/ls-lisp.el
index 56780da..2f723ca 100644
--- a/lisp/ls-lisp.el
+++ b/lisp/ls-lisp.el
@@ -61,7 +61,6 @@
 ;;; Code:
 
 
-(require 'em-glob)
 
 (defgroup ls-lisp nil
   "Emulate the ls program completely in Emacs Lisp."
@@ -481,8 +480,13 @@ not contain `d', so that a full listing is expected."
        (ding) (sit-for 2)))))          ; to show user the message!
 
 
+(declare-function eshell-extended-glob "em-glob" (glob))
+(declare-function dired-read-dir-and-switches "dired" (str))
+(declare-function dired-goto-next-file "dired" ())
+
 (defun ls-lisp--dired (orig-fun dir-or-list &optional switches)
   (interactive (dired-read-dir-and-switches ""))
+  (require 'em-glob)
   (if (consp dir-or-list)
       (funcall orig-fun dir-or-list switches)
     (let ((dir-wildcard (insert-directory-wildcard-in-dir-p



reply via email to

[Prev in Thread] Current Thread [Next in Thread]