[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Emacs-diffs] emacs-26 a2cc6d7: Fix Flymake help-echo functions across w
From: |
João Távora |
Subject: |
[Emacs-diffs] emacs-26 a2cc6d7: Fix Flymake help-echo functions across windows (bug#29142) |
Date: |
Sun, 5 Nov 2017 09:59:52 -0500 (EST) |
branch: emacs-26
commit a2cc6d74c5b94633e7fc044765e0ef40a8d63f50
Author: João Távora <address@hidden>
Commit: João Távora <address@hidden>
Fix Flymake help-echo functions across windows (bug#29142)
* lisp/progmodes/flymake.el (flymake--highlight-line): Use
with-selected-window.
(flymake-goto-next-error): Call help-echo with a window and an
overlay.
---
lisp/progmodes/flymake.el | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
index e13d797..e833cd9 100644
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -520,11 +520,12 @@ associated `flymake-category' return DEFAULT."
(flymake--fringe-overlay-spec
(overlay-get ov 'bitmap)))
(default-maybe 'help-echo
- (lambda (_window _ov pos)
- (mapconcat
- #'flymake--diag-text
- (flymake-diagnostics pos)
- "\n")))
+ (lambda (window _ov pos)
+ (with-selected-window window
+ (mapconcat
+ #'flymake--diag-text
+ (flymake-diagnostics pos)
+ "\n"))))
(default-maybe 'severity (warning-numeric-level :error))
(default-maybe 'priority (+ 100 (overlay-get ov 'severity))))
;; Some properties can't be overridden.
@@ -949,7 +950,7 @@ applied."
(message
"%s"
(funcall (overlay-get target 'help-echo)
- nil nil (point)))))
+ (selected-window) target (point)))))
(interactive
(user-error "No more Flymake errors%s"
(if filter
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Emacs-diffs] emacs-26 a2cc6d7: Fix Flymake help-echo functions across windows (bug#29142),
João Távora <=