emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] emacs-26 b8d74c4: Fix mark-defun when there's no spaces be


From: Alan Mackenzie
Subject: [Emacs-diffs] emacs-26 b8d74c4: Fix mark-defun when there's no spaces between successive defuns.
Date: Sat, 6 Jan 2018 06:55:08 -0500 (EST)

branch: emacs-26
commit b8d74c4578a6a4f1cabe993209358eb84883b869
Author: Alan Mackenzie <address@hidden>
Commit: Alan Mackenzie <address@hidden>

    Fix mark-defun when there's no spaces between successive defuns.
    
    The problem was a parse-partial-sexp call which tried to use the STOPBEFORE
    argument to detect non-syntactic WS.  This fails on a "}", which does not
    begin a sexp.
    
    * lisp/emacs-lisp/lisp.h (beginning-of-defun--in-emptyish-line-p): Enhance 
to
    handle BOL being in a string.
    (beginning-of-defun-comments): Call the above function in place of the call
    to parse-partial-sexp.
---
 lisp/emacs-lisp/lisp.el | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/lisp/emacs-lisp/lisp.el b/lisp/emacs-lisp/lisp.el
index 1777779..68d50e6 100644
--- a/lisp/emacs-lisp/lisp.el
+++ b/lisp/emacs-lisp/lisp.el
@@ -405,12 +405,13 @@ whitespace."
 ;; See https://lists.gnu.org/r/help-gnu-emacs/2016-08/msg00141.html
   (save-excursion
     (forward-line 0)
-    (< (line-end-position)
-       (let ((ppss (syntax-ppss)))
-         (when (nth 4 ppss)
-           (goto-char (nth 8 ppss)))
-         (forward-comment (point-max))
-         (point)))))
+    (let ((ppss (syntax-ppss)))
+      (and (null (nth 3 ppss))
+           (< (line-end-position)
+              (progn (when (nth 4 ppss)
+                       (goto-char (nth 8 ppss)))
+                     (forward-comment (point-max))
+                     (point)))))))
 
 (defun beginning-of-defun-comments (&optional arg)
   "Move to the beginning of ARGth defun, including comments."
@@ -428,10 +429,7 @@ whitespace."
                   (progn (skip-syntax-backward
                           "-" (line-beginning-position))
                          (not (bolp))) ; Check for blank line.
-                  (progn (parse-partial-sexp
-                          (line-beginning-position) (line-end-position)
-                          nil t (syntax-ppss (line-beginning-position)))
-                         (eolp))))) ; Check for non-comment text.
+                  (beginning-of-defun--in-emptyish-line-p)))) ; Check for 
non-comment text.
     (forward-line (if first-line-p 0 1))))
 
 (defvar end-of-defun-function



reply via email to

[Prev in Thread] Current Thread [Next in Thread]